Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect debug symbols should warn (not error) during builds #3200

Closed
spouliot opened this issue Jan 11, 2018 · 0 comments
Closed

Incorrect debug symbols should warn (not error) during builds #3200

spouliot opened this issue Jan 11, 2018 · 0 comments
Labels
bug If an issue is a bug or a pull request a bug fix iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac vs-sync *Only use when triaging (not before)* Syncs this bug with VSTS
Milestone
d15-7

Comments

@spouliot
Copy link
Contributor

spouliot commented Jan 11, 2018 •
edited by xamarin-release-manager

Steps to Reproduce

The issue can be seen with the (unmerged) tests from #3079 or bugzilla 61142

Expected Behavior

A warning reporting that the debugging symbols are incorrect (e.g. out of date) and that it might affect how the application can be debugged.

Actual Behavior

An MT0009 error. Beside the details being non-obvious (to solve) the workarounds are not ideal, e.g. deleting a .pdb from nuget would need to be done overtime it's cloned/refreshed and maybe updated (until fixed)

note: in 15.6 and earlier this was ignored.

Additional information

The reason for the error comes from fixing https://bugzilla.xamarin.com/show_bug.cgi?id=60277
So this needs to still work after the move to a warning.

VS bug #580950, VS bug #580951
@spouliot spouliot added bug If an issue is a bug or a pull request a bug fix macOS Issues affecting Xamarin.Mac iOS Issues affecting Xamarin.iOS labels Jan 11, 2018
@spouliot spouliot added this to the d15-7 milestone Jan 11, 2018
@spouliot spouliot self-assigned this Jan 11, 2018
spouliot added a commit to spouliot/xamarin-macios that referenced this issue Jan 12, 2018
@spouliot
[mtouch][mmp] Report invalid debug symbols files. Fixes xamarin#3200
ddb2ba9 
Try to read the assembly with symbols and, if that fails, warn and
fallback to loading them without symbols.

This fixes cases were it's not easy to update or delete (e.g. nuget)
bad symbols files - so this cannot be an error without causing a lot
of pain.

However it needs to be reported, otherwise it wont be fixed (by the
publisher) and it can limit the debugability of the application and
the usefulness of the stacktraces.

Finally merge most of the resolver's code between mtouch and mmp so
we don't have to fix such issue twice anymore.

note: this needs to be slightly updated once we get a version of cecil
that can give us a more precise error message.

Also bring Rolf's tests from
xamarin#3079

reference:
xamarin#3200
This was referenced Jan 12, 2018
Merged
Closed
@spouliot spouliot added the vs-sync *Only use when triaging (not before)* Syncs this bug with VSTS label Mar 12, 2018
@xamarin xamarin locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug If an issue is a bug or a pull request a bug fix iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac vs-sync *Only use when triaging (not before)* Syncs this bug with VSTS
Projects
None yet
Milestone
d15-7
Development

No branches or pull requests
1 participant
@spouliot