Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SceneKit.SCNSceneRenderer.OverlayScene property can not be null (but should be) #3392

Closed
mykyta-bondarenko opened this issue Feb 5, 2018 · 1 comment
Assignees
Labels
bug If an issue is a bug or a pull request a bug fix iOS Issues affecting Xamarin.iOS
Milestone

Comments

@mykyta-bondarenko
Copy link

mykyta-bondarenko commented Feb 5, 2018

I am working on the original Apple sample and found a difference between the API: I can set null to the
OverlayScene property using swift but can not do it using Xamarin.

Steps to Reproduce

  1. Create an instance of SCNView
  2. Set not-nullable value to the OverlayScene property
  3. Set null to the OverlayScene property

Expected Behavior

I can set null to the property and it will not crush.

Actual Behavior

System.ArgumentNullException has been thrown.

Environment

sceneRenderer?.overlaySKScene = nil
  • xamarin
this.sceneRenderer.OverlayScene = null;

Build Logs

Example Project

@spouliot
Copy link
Contributor

spouliot commented Feb 5, 2018

The ObjC documentation does not mention it's nullable

However it's optional on the swift documentation

@spouliot spouliot added bug If an issue is a bug or a pull request a bug fix iOS Issues affecting Xamarin.iOS labels Feb 5, 2018
@spouliot spouliot changed the title The SceneKit.ISCNSceneRenderer.OverlayScene property can not be null (but should be) The SceneKit.SCNSceneRenderer.OverlayScene property can not be null (but should be) Feb 5, 2018
@spouliot spouliot added this to the xcode9.3 milestone Feb 5, 2018
dalexsoto added a commit to dalexsoto/xamarin-macios that referenced this issue Feb 7, 2018
Fixes xamarin#3392

It seems swift has this property listed as an optional[0] and
an Apple sample[1] sets this to null so `ISCNSceneRenderer.OverlayScene`
needs to have `[NullAllowed]` even if ObjC headers do not have
nullability information.

[0]: https://developer.apple.com/documentation/scenekit/scnscenerenderer/1524051-overlayskscene
[1]: xamarin#3392
dalexsoto added a commit to dalexsoto/xamarin-macios that referenced this issue Feb 7, 2018
Fixes xamarin#3392

It seems swift has this property listed as an optional[0] and
an Apple sample[1] sets this to null so `ISCNSceneRenderer.OverlayScene`
needs to have `[NullAllowed]` even if ObjC headers do not have
nullability information.

[0]: https://developer.apple.com/documentation/scenekit/scnscenerenderer/1524051-overlayskscene
[1]: xamarin#3392
dalexsoto added a commit that referenced this issue Feb 7, 2018
Fixes #3392

It seems swift has this property listed as an optional[0] and
an Apple sample[1] sets this to null so `ISCNSceneRenderer.OverlayScene`
needs to have `[NullAllowed]` even if ObjC headers do not have
nullability information.

[0]: https://developer.apple.com/documentation/scenekit/scnscenerenderer/1524051-overlayskscene
[1]: #3392
dalexsoto added a commit to dalexsoto/xamarin-macios that referenced this issue Feb 7, 2018
…n#3410)

Fixes xamarin#3392

It seems swift has this property listed as an optional[0] and
an Apple sample[1] sets this to null so `ISCNSceneRenderer.OverlayScene`
needs to have `[NullAllowed]` even if ObjC headers do not have
nullability information.

[0]: https://developer.apple.com/documentation/scenekit/scnscenerenderer/1524051-overlayskscene
[1]: xamarin#3392
dalexsoto added a commit that referenced this issue Feb 7, 2018
…#3423)

Fixes #3392

It seems swift has this property listed as an optional[0] and
an Apple sample[1] sets this to null so `ISCNSceneRenderer.OverlayScene`
needs to have `[NullAllowed]` even if ObjC headers do not have
nullability information.

[0]: https://developer.apple.com/documentation/scenekit/scnscenerenderer/1524051-overlayskscene
[1]: #3392
@xamarin xamarin locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug If an issue is a bug or a pull request a bug fix iOS Issues affecting Xamarin.iOS
Projects
None yet
Development

No branches or pull requests

3 participants