Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSUrl.ItemTitle and .ItemUrl should be .PreviewItemTitle and .PreviewItemUrl #4450

Closed
mandel-macaque opened this issue Jul 17, 2018 · 3 comments
Closed

NSUrl.ItemTitle and .ItemUrl should be .PreviewItemTitle and .PreviewItemUrl #4450

mandel-macaque opened this issue Jul 17, 2018 · 3 comments
Assignees
@mandel-macaque
Labels
breaking-change If an issue or a pull request represents a breaking change enhancement The issue or pull request is an enhancement iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac
Milestone
XAMCORE_4_0

Comments

@mandel-macaque
Copy link
Member

From @MichaelNorman on July 13, 2018 20:0

NSUrl.ItemTitle and NSUrl.ItemUrl should be NSUrl.PreviewItemTitle and NSUrl.PreviewItemUrl, respectively. They bind .previewItemTitle and .previewItemURL.

Expected:
NSUrl.PreviewItemTitle and NSUrl.PreviewItemUrl

Actual:
NSUrl.ItemTitle and NSUrl.ItemUrl

Copied from original issue: xamarin/maccore#885
@mandel-macaque
Copy link
Member Author

Hello, thanks for the bug report, but this is the private repo for the tools that are related to Xamarin.[iOS|Mac]. I'll close the issue and will move it to the correct project.

@VincentDondain
Copy link
Contributor

We acknowledge this enhancement request. However this is a breaking change on a protocol so it would only be effective if we even break the APIs again.

@VincentDondain VincentDondain added this to the Future milestone Jul 18, 2018
@VincentDondain VincentDondain added the enhancement The issue or pull request is an enhancement label Jul 18, 2018
@VincentDondain
Copy link
Contributor

Also this happens here: https://github.com/xamarin/xamarin-macios/blob/master/src/quicklook.cs#L126-L139 (it's a protocol that NSUrl conforms to).

@mandel-macaque mandel-macaque modified the milestones: Future, XAMCORE_4_0 Aug 22, 2018
@VincentDondain VincentDondain added the breaking-change If an issue or a pull request represents a breaking change label Aug 27, 2018
@rolfbjarne rolfbjarne added macOS Issues affecting Xamarin.Mac iOS Issues affecting Xamarin.iOS labels Sep 3, 2018
@mandel-macaque mandel-macaque self-assigned this Sep 20, 2018
mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this issue Sep 20, 2018
@mandel-macaque
[QuickLook] Use the correct name properties in QLPreviewItem. Fixes x…
2f853c8 
…amarin#4450

Renamed properties for the next time we can make breaking changes.

Fixes xamarin#4450
@mandel-macaque mandel-macaque mentioned this issue Sep 20, 2018
Merged
mandel-macaque added a commit that referenced this issue Sep 21, 2018
@mandel-macaque
[QuickLook] Use the correct name properties in QLPreviewItem. Fixes #…
dd4904f 
…4450 (#4855)

* [QuickLook] Use the correct name properties in QLPreviewItem. Fixes #4450

Renamed properties for the next time we can make breaking changes.

Fixes #4450
@xamarin xamarin locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mandel-macaque mandel-macaque

Labels
breaking-change If an issue or a pull request represents a breaking change enhancement The issue or pull request is an enhancement iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac
Projects
None yet
Milestone
XAMCORE_4_0
Development

No branches or pull requests
3 participants
@rolfbjarne @mandel-macaque @VincentDondain