Smart removal of custom attributes #6048
Labels
enhancement
The issue or pull request is an enhancement
iOS
Issues affecting Xamarin.iOS
macOS
Issues affecting Xamarin.Mac
Milestone
Comments
spouliot
added
enhancement
spouliot
pushed a commit
to spouliot/xamarin-macios
that referenced
this issue
May 14, 2019
…timization. Fix xamarin#3655 This allows the optimization to be disabled in cases where one, or many, a custom attribute(s) are required by the application at runtime. While not ideal disabling this single step is much better than disabling linking for the whole application. A better approach is described in xamarin#6048 but this configuration optimization makes sense independently of it. Fix xamarin#3655
monojenkins
pushed a commit
to monojenkins/xamarin-macios
that referenced
this issue
May 16, 2019
…timization. Fix xamarin#3655 This allows the optimization to be disabled in cases where one, or many, a custom attribute(s) are required by the application at runtime. While not ideal disabling this single step is much better than disabling linking for the whole application. A better approach is described in xamarin#6048 but this configuration optimization makes sense independently of it. Fix xamarin#3655
spouliot
added a commit
that referenced
this issue
May 16, 2019
…timization. Fix #3655 (#6049) This allows the optimization to be disabled in cases where one, or many, a custom attribute(s) are required by the application at runtime. While not ideal disabling this single step is much better than disabling linking for the whole application. A better approach is described in #6048 but this configuration optimization makes sense independently of it. Fix #3655
spouliot
pushed a commit
that referenced
this issue
May 16, 2019
…rable optimization. Fix #3655 (#6058) This allows the optimization to be disabled in cases where one, or many, a custom attribute(s) are required by the application at runtime. While not ideal disabling this single step is much better than disabling linking for the whole application. A better approach is described in #6048 but this configuration optimization makes sense independently of it. Fix #3655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following up #3655 (comment)
The existing custom attribute removal is, largely, based on a static list.
A better approach would be to make this closer to the metadata removal of parameter names. IOW if user (non SDK) code does not reference an attribute then it can be removed (from all assemblies, not only the linked ones).
The text was updated successfully, but these errors were encountered: