[StoreKit] Update framework to Xcode 12 beta 4. #9387

mandel-macaque · 2020-08-17T13:42:32Z

No description provided.

spouliot · 2020-08-17T14:21:28Z

src/storekit.cs

+
+		[Watch (7, 0), TV (14, 0), Mac (11, 0), iOS (14, 0)]
+		[Export ("transactionObservers")]
+		[Protocolize]


we stopped using this after XAMCORE_2_0 - that was only useful when supporting classic
use the interface for the protocol instead

side note: we have warnings about exposing concrete (vs interface) types in bindings but I'm not 💯% sure they all work with [Protocolize]

They do not, and I used because it was already in the file, doing it the right way.

spouliot · 2020-08-17T14:23:54Z

src/storekit.cs

@@ -525,34 +545,51 @@ interface SKStoreProductViewController {
 		void LoadProduct (StoreProductParameters parameters, [NullAllowed] Action<bool,NSError> callback);
 	}

+	[Mac (11,0), NoTV, NoWatch]


missing [iOS] attribute

hmm... that was moved :(
I rather have more #if XXX than moving code (to preserve git history)

Was added in iOS 6,0.

yeah, larger diff (than required) due to code being moved

src/storekit.cs

spouliot · 2020-08-17T14:30:08Z

src/storekit.cs

@@ -797,9 +834,16 @@ interface SKProductStorePromotionController {
 	[DisableDefaultCtor] // Not specified but very likely
 	interface SKStoreReviewController {

+		[Deprecated (PlatformName.iOS, 9, 0, message : "Use the 'RequestReview (UIWindowScene windowScene)' API instead.")]


nope, because

this API was added in iOS 10.3 - so it can't be deprecated in iOS 9.0

UIWindowScene was added in iOS 13 (iirc)

spouliot · 2020-08-17T14:31:10Z

src/storekit.cs

 		[Static]
 		[Export ("requestReview")]
 		void RequestReview ();
+
+		[Introduced (PlatformName.MacCatalyst, 14, 0)]
+		[NoWatch, NoTV, iOS (14,0), Mac (11,0)]


[Mac (11,0)] is incorrect as UIWindowScene does not exists in macOS
This compiled because you defined it to be NSObject but that won't work at runtime

src/storekit.cs

spouliot · 2020-08-17T14:34:33Z

src/storekit.cs

+		[DesignatedInitializer]
+		IntPtr Constructor (SKOverlayConfiguration configuration);
+
+		[iOS (14,0)]


not needed (already on type)

spouliot · 2020-08-17T14:34:38Z

src/storekit.cs

+		[Export ("presentInScene:")]
+		void PresentInScene (UIWindowScene scene);
+
+		[iOS (14,0)]


not needed (already on type)

monojenkins · 2020-08-17T16:13:41Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 75 tests passed.

Failed tests

introspection/tvOS - simulator/Debug (tvOS 10.2): Failed

src/storekit.cs

rolfbjarne · 2020-08-17T17:02:33Z

src/storekit.cs

+#if XAMCORE_3_0 // Avoid breaking change in iOS
+	[DisableDefaultCtor]
+#endif
+	interface SKCloudServiceController {


Any reason to move this class? It makes the diff harder to review :/

Moved it out of the #if over adding extra #if #else

yeah, better the extra #if next time
or do a separate PR to move things
moving and adding makes the diff more difficult to review

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

…marin-macios into storekit-xcode12-beta4

spouliot · 2020-08-17T18:04:02Z

src/storekit.cs

@@ -525,34 +546,59 @@ interface SKStoreProductViewController {
 		void LoadProduct (StoreProductParameters parameters, [NullAllowed] Action<bool,NSError> callback);
 	}

+	[Mac (11,0), NoTV, NoWatch]
+	[BaseType (typeof (NSObject))]
+	[Model (AutoGeneratedName = true)]


did you add AutoGeneratedName = true
iirc that's a potential breaking change in existing models
c.c. @rolfbjarne

@spouliot added as per @rolfbjarne request

hmm... is this a new type ? (then it needs it)
or does it look new because the diff is hard to read (and the code just moved) ? (then I don't think it should be there)

It was moved. So no need.

Suggested change

[Model (AutoGeneratedName = true)]

[Model]

Please don't resolve a conversation you have not started. Makes things harder to review again.

monojenkins · 2020-08-17T21:46:48Z

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

monojenkins · 2020-08-18T02:11:57Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 75 tests passed.

Failed tests

introspection/tvOS - simulator/Debug (tvOS 10.2): Failed

rolfbjarne · 2020-08-18T08:28:13Z

src/StoreKit/SKOverlayAppClipConfiguration.cs

+	}
+#endif
+}
+#endif


No new line at end of file

rolfbjarne · 2020-08-18T08:28:26Z

src/StoreKit/SKOverlayAppConfiguration.cs

+	}
+#endif
+}
+#endif


No newline at end of file

…marin-macios into storekit-xcode12-beta4

monojenkins · 2020-08-18T16:58:08Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

2 tests failed, 74 tests passed.

Failed tests

Xtro/Mac: Failed (Test run failed.)
introspection/tvOS - simulator/Debug (tvOS 10.2): Failed

monojenkins · 2020-08-18T23:55:09Z

Build success
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

[StoreKit] Update framework to Xcode 12 beta 4.

cb3a46a

mandel-macaque requested a review from spouliot as a code owner August 17, 2020 13:42

spouliot suggested changes Aug 17, 2020

View reviewed changes

Merge branch 'xcode12' into storekit-xcode12-beta4

fc3c22a

whitneyschmidt approved these changes Aug 17, 2020

View reviewed changes

rolfbjarne requested changes Aug 17, 2020

View reviewed changes

mandel-macaque and others added 3 commits August 17, 2020 13:43

Address reviews.

6a5e1cf

Apply suggestions from code review

82e6a89

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Merge branch 'storekit-xcode12-beta4' of github.com:mandel-macaque/xa…

bf0fb9f

…marin-macios into storekit-xcode12-beta4

spouliot reviewed Aug 17, 2020

View reviewed changes

Update src/storekit.cs

29d8620

rolfbjarne approved these changes Aug 18, 2020

View reviewed changes

spouliot approved these changes Aug 18, 2020

View reviewed changes

mandel-macaque added 2 commits August 18, 2020 10:52

Fix intro issues on tvOS.

a9c4175

Merge branch 'storekit-xcode12-beta4' of github.com:mandel-macaque/xa…

8ed333e

…marin-macios into storekit-xcode12-beta4

Fix small issues with tvOS.

ea14d94

mandel-macaque merged commit 5ba2042 into xamarin:xcode12 Aug 19, 2020

mandel-macaque deleted the storekit-xcode12-beta4 branch August 19, 2020 00:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[StoreKit] Update framework to Xcode 12 beta 4. #9387

[StoreKit] Update framework to Xcode 12 beta 4. #9387

mandel-macaque commented Aug 17, 2020

spouliot Aug 17, 2020

mandel-macaque Aug 17, 2020

spouliot Aug 17, 2020

spouliot Aug 17, 2020

mandel-macaque Aug 17, 2020

spouliot Aug 17, 2020

spouliot Aug 17, 2020

spouliot Aug 17, 2020

spouliot Aug 17, 2020

spouliot Aug 17, 2020

monojenkins commented Aug 17, 2020

Failed tests

rolfbjarne Aug 17, 2020

mandel-macaque Aug 17, 2020

spouliot Aug 17, 2020

spouliot Aug 17, 2020

mandel-macaque Aug 17, 2020

spouliot Aug 17, 2020

mandel-macaque Aug 17, 2020

spouliot Aug 18, 2020

monojenkins commented Aug 17, 2020

monojenkins commented Aug 18, 2020

Failed tests

rolfbjarne Aug 18, 2020

rolfbjarne Aug 18, 2020

monojenkins commented Aug 18, 2020

Failed tests

monojenkins commented Aug 18, 2020

[StoreKit] Update framework to Xcode 12 beta 4. #9387

[StoreKit] Update framework to Xcode 12 beta 4. #9387

Conversation

mandel-macaque commented Aug 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Aug 17, 2020

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Aug 17, 2020

monojenkins commented Aug 18, 2020

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Aug 18, 2020

Test results

Failed tests

monojenkins commented Aug 18, 2020