Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fileprovider] Update for Xcode 12 beta 6 #9581

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

spouliot
Copy link
Contributor

@spouliot spouliot commented Sep 3, 2020

This was quite noisy. Apple removed all API marked as
FILEPROVIDER_API_AVAILABILITY_V3.

#define FILEPROVIDER_API_AVAILABILITY_V3 API_UNAVAILABLE(watchos, tvos) API_UNAVAILABLE(ios, macos, macCatalyst)

Most were bound but they were (majority) decorated with [NoiOS] and
[NoMac] so they did not generated any bindings.

A few of them were modified or just became macOS-only.

Deprecation warnings also needed to be updated.

This was quite noisy. Apple removed all API marked as
`FILEPROVIDER_API_AVAILABILITY_V3`.

```
```

Most were bound but they were (majority) decorated with `[NoiOS]` and
`[NoMac]` so they did not generated any bindings.

A few of them were modified or just became macOS-only.

Deprecation warnings also needed to be updated.
@spouliot spouliot added this to the xcode12 milestone Sep 3, 2020
@spouliot spouliot mentioned this pull request Sep 3, 2020
46 tasks
src/foundation.cs Outdated Show resolved Hide resolved
@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
Test run succeeded

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that took quite a while to review vs diffs heh, LGTM 👍

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@spouliot spouliot merged commit 0de4daa into xamarin:xcode12 Sep 4, 2020
@spouliot spouliot deleted the xcode12-fileprovider-b6 branch September 4, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants