[xcode12][mediaplayer] Fix MPMusicPlayerController NowPlayingItem on recent iOS versions #9619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recent iOS versions Rolf nailed the issue in xamarin#9578 (comment) > The problem is that iOS returns an instance of a private type (_MPMusicPlayerMediaItemProxy) which is an NSProxy subclass, and currently we don't support NSProxy. rolfbjarne@873a1e1 was on the right track but it turns out `[ForcedType]` on properties don't need, nor work (same generated code), with `return:`. Inside `DynamicRegistrar.cs` the method ```csharp public Type Lookup (IntPtr @Class, bool throw_on_error) ``` did not respect (was unused) the `throw_on_error`. That made it impossible to force the type to the pointer we got. In `Runtime.cs` the method `LookupINativeObjectImplementation` must also be able to work without an exception (from the `Lookup`) at least when we want to force the type. backport of xamarin#9604 reference: xamarin#9578
rolfbjarne
approved these changes
Sep 10, 2020
dalexsoto
approved these changes
Sep 10, 2020
|
Build success |
chamons
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolf nailed the issue in #9578 (comment)
rolfbjarne@873a1e1 was on the
right track but it turns out
[ForcedType]on properties don't need, norwork (same generated code), with
return:.Inside
DynamicRegistrar.csthe methoddid not respect (was unused) the
throw_on_error. That made itimpossible to force the type to the pointer we got.
In
Runtime.csthe methodLookupINativeObjectImplementationmust alsobe able to work without an exception (from the
Lookup) at least when wewant to force the type.
backport of #9604
reference: #9578