Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LinkPresentation] Xcode 13 Beta 1 Changes #11943

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

tj-devel709
Copy link
Contributor

I believe this one should have the Mac Catalyst header:

  1. The method documentation says supported in mac catalyst https://developer.apple.com/documentation/linkpresentation/lpmetadataprovider/3752081-startfetchingmetadataforrequest?language=objc
  2. The interface also says it supports mac catalyst https://developer.apple.com/documentation/linkpresentation/lpmetadataprovider?language=objc
  3. This method was in the mac catalyst todo file

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jun 15, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jun 15, 2021
@tj-devel709
Copy link
Contributor Author

Question: The wiki says this is also available in tvOS but there was not todo file for tvOS, the online docs do not mention tv, sharpie did not have any tv availability, and the tests passed locally. I can assume that the wiki was lying, right?

@spouliot
Copy link
Contributor

Question: The wiki says this is also available in tvOS but there was not todo file for tvOS, the online docs do not mention tv, sharpie did not have any tv availability, and the tests passed locally. I can assume that the wiki was lying, right?

What the wiki (Xcode-diff) tells you is that the headers for tvOS has the symbol - but it does not mean the symbol is available on tvOS.

This often happens because the same header files are shared (good thing) across all platforms.

If you look at https://developer.apple.com/documentation/linkpresentation/lpmetadataprovider?language=objc you'll see that the tvOS is not mentioned for the type. Now web docs are often incorrect so a better way to check this is to open the header file (path included in the wiki's diff).

LP_EXTERN API_AVAILABLE(macos(10.15), ios(13.0)) API_UNAVAILABLE(watchos, tvos)
@interface LPMetadataProvider : NSObject

As you'll have confirmation that, in this case, the type is not available on tvOS - so it make sense that none of it's member will be available (unless there's a mistake somewhere... that can happen)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 84 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2621 Passed: 2461 Inconclusive: 32 Failed: 1 Ignored: 159)
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1099.BigSur'
Merge 5a76d8c into acf03b5

@tj-devel709
Copy link
Contributor Author

There are 2 unrelated test failures:

@tj-devel709 tj-devel709 merged commit dbacb3b into xamarin:main Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants