Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VideoSubscriberAccount] Updates for Xcode13 Beta 1 #11977

Merged
merged 5 commits into from Jun 23, 2021
Merged

[VideoSubscriberAccount] Updates for Xcode13 Beta 1 #11977

merged 5 commits into from Jun 23, 2021

Conversation

tj-devel709
Copy link
Contributor

There were a lot of items inside the MacCatalyst todo file.
After running introspection tests, checking the web docs for all of them, and the xcode headers for most of them,
it does not look like they are valid to be marked for MacCatalyst.

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jun 17, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jun 17, 2021
mandel-macaque
mandel-macaque requested changes Jun 18, 2021
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is an API that is not present in the platforms, it does not go to the ignore file, but we use a No*Attr, in all those, you should have used [NoMacCatalyst] like here: https://github.com/xamarin/xamarin-macios/blob/main/src/uikit.cs#L1519

@tj-devel709
Copy link
Contributor Author

If there is an API that is not present in the platforms, it does not go to the ignore file, but we use a No*Attr, in all those, you should have used [NoMacCatalyst] like here: https://github.com/xamarin/xamarin-macios/blob/main/src/uikit.cs#L1519

Ah so we add the NoMacCatalyst and remove it from the ignore?

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 8c0e292 into abca8f1

@spouliot
Copy link
Contributor

Part of the issue is that

	VideoSubscriberAccount \

is part of of MACCATALYST_FRAMEWORKS = inside src/frameworks.sources

So the bindings are included in Catalyst - and that means you must tell the generator not to process stuff that is not available on that platform.

Now looking back at the framework headers it seems that everything is not available at Catalyst, so you can remove its inclusion.

However to help "future you", the day Apple starts to include it, you better add the same [NoMacCatalyst] to new API when it's documented that way in the header files.

@tj-devel709
Copy link
Contributor Author

@spouliot So after I removed VideoSubscriberAccount from the frameworks.sources and removed the ignore file, xtro still complains saying the items are not bound in MacCatalyst. So I still need the NoMacCatalyst right?

@spouliot
Copy link
Contributor

xtro still complains saying the items are not bound in MacCatalyst

I'm not sure why xtro pick the API as missing :(
There might be a bad macro somewhere since the headers are clear

/// A VSAccountManager instance coordinates access to a subscriber's account.
API_AVAILABLE(ios(10.0), tvos(10.0)) API_UNAVAILABLE(macCatalyst)
@protocol VSAccountManagerDelegate <NSObject>

So I still need the NoMacCatalyst right?

You should add it (like my previous comment about "future you") as it might become useful later. However that won't solve the problem.

Open an issue (for xtro) and add a link to it inside the macCatalyst-VideoSubscriberAccount.ignore. I'll have a look why later (but that might be after my vacations).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 83 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)
  • link sdk/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1094.BigSur'
Merge bb69273 into aaf8d70

@tj-devel709
Copy link
Contributor Author

@spouliot @mandel-macaque
I removed this API from the frameworks.sources under MacCatalyst
Then VSSubscriptionAccessLevel and VSSubscriptionAccess started complaining about not being in MacCatalyst so I added the NoMacCatalyst to those as well and added all the selectors xtro was complaining about to the ignore file as well as linked this issue here https://github.com/xamarin/maccore/issues/2462

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge d43dc1c into 4bc32a9

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 84 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2622 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 132)
  • Xtro/Mac: Failed (Test run failed.)

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 4bef5c3 into 6ce5f80

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1101.BigSur'
Merge f3802ea into 0e07b98

@tj-devel709 tj-devel709 merged commit c4d5433 into xamarin:main Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@dalexsoto dalexsoto Awaiting requested review from dalexsoto dalexsoto is a code owner

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
xcode13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tj-devel709 @vs-mobiletools-engineering-service2 @spouliot @rolfbjarne @mandel-macaque