[CoreAudioTypes] Updates for Xcode13 Beta2 #12068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tj-devel709
added
the
note-highlight
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1100.BigSur' |
mandel-macaque
approved these changes
Jul 7, 2021
rachelkang
reviewed
Jul 7, 2021
| @@ -470,6 +470,8 @@ public enum AudioChannelLabel : int { // UInt32 AudioChannelLabel | |||
| HoaAcn14 = (2 << 16) | 14, | |||
| HoaAcn15 = (2 << 16) | 15, | |||
| HoaAcn65024 = (2 << 16) | 65024, | |||
| HoaSn3d = HoaAcn0, | |||
There was a problem hiding this comment.
Why is it HoaAcn0 and not kAudioChannelLabel_HOA_ACN_0 ?
I also can't find these on the web docs, hmm
There was a problem hiding this comment.
Yeah the full name is kAudioChannelLabel_HOA_ACN_0 but the enum elements that were already here were shortened to things like HoaAcn0 I guess just for easier usability!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.