Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SafariServices] Update to Xcode13 beta1 #12102

Merged
merged 15 commits into from
Jul 26, 2021
Merged

[SafariServices] Update to Xcode13 beta1 #12102

merged 15 commits into from
Jul 26, 2021

Conversation

tj-devel709
Copy link
Contributor

No description provided.

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jul 12, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jul 12, 2021
@tj-devel709
Copy link
Contributor Author

Whoops, forgot to delete the todos

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • introspection/iOS Unified 64-bits - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1098.BigSur'
Merge ff62519 into 9207b59

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 84 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2626 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 135)
  • monotouch-test/tvOS - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1097.BigSur'
Merge bbcb778 into dba3bf3

spouliot
spouliot suggested changes Jul 19, 2021
View reviewed changes
src/safariservices.cs Outdated Show resolved Hide resolved
src/safariservices.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1098.BigSur'
Merge 5014482 into e968a93

mandel-macaque
mandel-macaque requested changes Jul 20, 2021
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge with main too.

tests/xtro-sharpie/MacCatalyst-SafariServices.ignore Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 2d9cc11 into 09f911b

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

5 tests failed, 81 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2494 Inconclusive: 35 Failed: 1 Ignored: 134)
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: TimedOut
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): TimedOut
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): TimedOut
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): TimedOut

Pipeline on Agent XAMBOT-1106.BigSur'
Merge 677e6b0 into eea8142

tj-devel709
tj-devel709 commented Jul 21, 2021
View reviewed changes
src/safariservices.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 86 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2490 Inconclusive: 35 Failed: 3 Ignored: 136)
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
  • link sdk/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 129 Passed: 105 Inconclusive: 6 Failed: 1 Ignored: 23)

Pipeline on Agent XAMBOT-1106.BigSur'
Merge 30c999c into 4060387

@tj-devel709
Copy link
Contributor Author

Updating to fix unrelated failure: https://github.com/xamarin/maccore/issues/2472

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2484 Inconclusive: 35 Failed: 4 Ignored: 141)

Pipeline on Agent XAMBOT-1098.BigSur'
Merge 6bc5554 into 28bb8bc

@tj-devel709
Copy link
Contributor Author

Unrelated Test Failures: https://github.com/xamarin/maccore/issues/2443 and https://github.com/xamarin/maccore/issues/2471

@tj-devel709
Copy link
Contributor Author

Fixing merge conflicts ^

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 87 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2486 Inconclusive: 35 Failed: 2 Ignored: 141)
  • link all/Mac Catalyst/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1097.BigSur
Merge d243f67 into c0651c9

@tj-devel709
Copy link
Contributor Author

Unrelated Test Failures:
monotouch-test/Mac Catalyst/Debug [dotnet]: https://github.com/xamarin/maccore/issues/2471
link all/Mac Catalyst/Debug [dotnet]: https://github.com/xamarin/maccore/issues/2414

@tj-devel709 tj-devel709 merged commit 149434d into xamarin:main Jul 26, 2021
@dalexsoto dalexsoto added this to July 2021 in Xcode 13 Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandel-macaque mandel-macaque mandel-macaque requested changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@spouliot spouliot spouliot approved these changes

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
No open projects
Xcode 13
July 2021
Milestone
xcode13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tj-devel709 @vs-mobiletools-engineering-service2 @rolfbjarne @spouliot @mandel-macaque