Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoreWLan] Add XCode13 beta 1 support. #12103

Merged
merged 7 commits into from Jul 19, 2021
Merged

[CoreWLan] Add XCode13 beta 1 support. #12103

merged 7 commits into from Jul 19, 2021

Conversation

mandel-macaque
Copy link
Member

Added support for MacCatalyst and cleaned the backlog.

@mandel-macaque
[CoreWLan] Add XCode13 beta 1 support.
a4b36ec 
Added support for MacCatalyst and cleaned the backlog.
@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Jul 12, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 86 tests passed.

Failed tests

  • introspection/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 37 Passed: 34 Inconclusive: 0 Failed: 2 Ignored: 1)
  • introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 38 Inconclusive: 0 Failed: 1 Ignored: 5)
  • link all/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1097.BigSur'
Merge a4b36ec into 9207b59

rolfbjarne
rolfbjarne requested changes Jul 13, 2021
View reviewed changes
tests/xammac_tests/xammac_tests.csproj Outdated Show resolved Hide resolved
tests/xammac_tests/CoreWlan/CWKeychainTests.cs Outdated Show resolved Hide resolved
tests/xammac_tests/CoreWlan/CWKeychainTests.cs Outdated Show resolved Hide resolved
src/CoreWlan/CWKeychain.cs Outdated Show resolved Hide resolved
src/CoreWlan/CWKeychain.cs Outdated Show resolved Hide resolved
src/corewlan.cs Outdated Show resolved Hide resolved
src/corewlan.cs Outdated
[BaseType (typeof (CWConfiguration))]
interface CWMutableConfiguration {

[Mac (10, 7)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/corewlan.cs Outdated Show resolved Hide resolved
src/corewlan.cs Outdated Show resolved Hide resolved
src/corewlan.cs Outdated Show resolved Hide resolved
@mandel-macaque @rolfbjarne
Apply suggestions from code review
80397a4 
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 80397a4 into 33f8143

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 85 tests passed.

Failed tests

  • introspection/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 37 Passed: 34 Inconclusive: 0 Failed: 2 Ignored: 1)
  • introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 38 Inconclusive: 0 Failed: 1 Ignored: 5)
  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2625 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 135)
  • xcframework-test/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1097.BigSur'
Merge 80397a4 into 33f8143

rolfbjarne
rolfbjarne requested changes Jul 14, 2021
View reviewed changes
src/CoreWlan/CWKeychain.cs Outdated Show resolved Hide resolved
src/CoreWlan/CWKeychain.cs Outdated Show resolved Hide resolved
src/CoreWlan/CWKeychain.cs Show resolved Hide resolved
src/CoreWlan/CWKeychain.cs Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 86 tests passed.

Failed tests

  • introspection/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 37 Passed: 35 Inconclusive: 0 Failed: 1 Ignored: 1)
  • introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 38 Inconclusive: 0 Failed: 1 Ignored: 5)
  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2626 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 135)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 21156e0 into dacf374

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 85 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: BuildFailure
  • xammac tests/Mac Modern/Release: BuildFailure
  • xammac tests/Mac Modern/Release (all optimizations): BuildFailure
  • monotouch-test/Mac [dotnet]/Debug [dotnet]: BuildFailure

Pipeline on Agent XAMBOT-1098.BigSur'
Merge a01d88c into dba3bf3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 89 tests passed 🎉

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 034cb18 into dba3bf3

@mandel-macaque mandel-macaque merged commit a96421f into xamarin:main Jul 19, 2021
@mandel-macaque mandel-macaque deleted the corewlan-xcode13-beta1 branch July 19, 2021 13:02
@dalexsoto dalexsoto added this to July 2021 in Xcode 13 Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@spouliot spouliot Awaiting requested review from spouliot

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
No open projects
Xcode 13
July 2021
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mandel-macaque @vs-mobiletools-engineering-service2 @rolfbjarne