[SceneKit] Update bindings for Xcode13.0 beta 1 & beta 2 #12121
Conversation
rachelkang
added
the
note-highlight
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1098.BigSur' |
There was a problem hiding this comment.
Approving, please address @rolfbjarne comment regarding the binders.
| @@ -283,7 +283,7 @@ public enum SCNAntialiasingMode : ulong { | |||
| None, | |||
| Multisampling2X, | |||
| Multisampling4X, | |||
| #if MONOMAC | |||
| #if MONOMAC || __MACCATALYST__ | |||
There was a problem hiding this comment.
Is catalyst support new new in Xcode 13 ?
In that case there should be a [MacCatalyst (15,0)] on each member
There was a problem hiding this comment.
No, it's not new new! I think I only got this because of the xtro - header files don't mention it, and web docs indicate 13.1 https://developer.apple.com/documentation/scenekit/scnantialiasingmode
| !missing-selector! SCNRenderer::render not bound | ||
|
|
||
| # adding abstract member to an existing type would be a breaking change | ||
| !incorrect-protocol-member! SCNAnimatable::removeAllAnimationsWithBlendOutDuration: is REQUIRED and should be abstract |
There was a problem hiding this comment.
when something needs to be annotated for all platforms then you should add it to the common-*.ignore file
There was a problem hiding this comment.
got it, thank you!
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1101.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1105.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 88 tests passed.Failed tests
Pipeline on Agent XAMBOT-1106.BigSur' |
|
Unrelated test failure: https://github.com/xamarin/maccore/issues/2443 |
|
Beta 4 is out, we should wait for the bump PR to land |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 88 tests passed.Failed tests
Pipeline on Agent XAMBOT-1108.BigSur' |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 88 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
|
Diff failures, with looks like https://github.com/xamarin/maccore/issues/2414 |
No description provided.