Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLCompute] Add support for Xcode 13 beta 4. #12348

Merged
merged 3 commits into from Aug 5, 2021

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Aug 4, 2021
[SupportedOSPlatform ("macos12.0")]
#else
[NoWatch]
[TV (15,0), Mac (12,0), iOS (15,0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catalyst ?

src/mlcompute.cs Show resolved Hide resolved
src/mlcompute.cs Show resolved Hide resolved
src/mlcompute.cs Outdated
@@ -229,6 +237,14 @@ enum MLCSoftmaxOperation {
LogSoftmax = 1,
}

[iOS (15,0), TV (15,0), Mac (12,0), NoWatch]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catalyst ?

src/mlcompute.cs Outdated
@@ -538,11 +596,21 @@ interface MLCDevice : NSCopying {
[return: NullAllowed]
MLCDevice GetDevice (IMTLDevice[] gpus);

[TV (15,0), Mac (12,0), iOS (15,0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catalyst ?

src/mlcompute.cs Outdated

[Static]
[Export ("setRNGSeedTo:")]
void SetRngSeedTo ([BindAs (typeof (nuint))] NSNumber seed);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> SetRngSeed

src/mlcompute.cs Show resolved Hide resolved
src/mlcompute.cs Outdated
NSNumber GetRngSeed ();
}

[TV (15,0), Mac (12,0), iOS (15,0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catalyst ?

src/mlcompute.cs Outdated Show resolved Hide resolved
tests/xtro-sharpie/common-MLCompute.ignore Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 6b5e6ae into fa5f323

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 89 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2630 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 139)

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 7a0f9fe into fa5f323

@mandel-macaque
Copy link
Member Author

Unrelated issue: https://github.com/xamarin/maccore/issues/2443

@mandel-macaque mandel-macaque merged commit 818198b into xamarin:main Aug 5, 2021
@mandel-macaque mandel-macaque deleted the mlcompute-xcode13-beta4 branch August 5, 2021 05:02
@dalexsoto dalexsoto added this to August 2021 in Xcode 13 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
No open projects
Xcode 13
August 2021
Development

Successfully merging this pull request may close these issues.

None yet

3 participants