[CoreAudio] Updates for Xcode13 Beta 5 #12465
Conversation
tj-devel709
added
the
note-highlight
| @@ -187,7 +187,9 @@ public enum AudioObjectPropertySelector : uint | |||
| TranslateUIDToBox = 1969841250, // 'uidb' | |||
| ClockDeviceList = 1668049699, //'clk#' | |||
| TranslateUidToClockDevice = 1969841251, // 'uidc', | |||
| [Obsolete ("Use the 'ProcessIsMain' element instead.")] | |||
There was a problem hiding this comment.
You are missing the deprecated attrs:
[Deprecated (PlatformName.TvOS, 15,0)]
you will have to add them for each of the supported platforms.
There was a problem hiding this comment.
unlike the other enum this one has a different value so it's useful to know when it should be avoided
| ProcessIsMaster = 1835103092, // 'mast' | ||
| ProcessIsMain = 1835100526, // 'main' |
There was a problem hiding this comment.
AFAIK we should say when it was added.
There was a problem hiding this comment.
With a comment?
| @@ -200,6 +202,7 @@ public enum AudioObjectPropertySelector : uint | |||
| ActualSampleRate = 1634955892,// 'asrt', | |||
| ClockDevice = 1634755428, // 'apcd', | |||
| IOThreadOSWorkgroup = 1869838183, // 'oswg' | |||
| ProcessMute = 1634758765, // 'appm' | |||
There was a problem hiding this comment.
^ needs availability attributes - for both NET and legacy
There was a problem hiding this comment.
if it's not available in tvOS then it needs [NoTV] and [SupportedOSPlatform ("tvos")]
unless the enum type itself is not available ?
otherwise it implies availability for tvOS 9 (for legacy) or tvOS 10 (for net6)
| @@ -187,7 +187,9 @@ public enum AudioObjectPropertySelector : uint | |||
| TranslateUIDToBox = 1969841250, // 'uidb' | |||
| ClockDeviceList = 1668049699, //'clk#' | |||
| TranslateUidToClockDevice = 1969841251, // 'uidc', | |||
| [Obsolete ("Use the 'ProcessIsMain' element instead.")] | |||
There was a problem hiding this comment.
unlike the other enum this one has a different value so it's useful to know when it should be avoided
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 103 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
|
@spouliot and others |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
| @@ -200,6 +202,7 @@ public enum AudioObjectPropertySelector : uint | |||
| ActualSampleRate = 1634955892,// 'asrt', | |||
| ClockDevice = 1634755428, // 'apcd', | |||
| IOThreadOSWorkgroup = 1869838183, // 'oswg' | |||
| ProcessMute = 1634758765, // 'appm' | |||
There was a problem hiding this comment.
if it's not available in tvOS then it needs [NoTV] and [SupportedOSPlatform ("tvos")]
unless the enum type itself is not available ?
otherwise it implies availability for tvOS 9 (for legacy) or tvOS 10 (for net6)
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
|
@tj-devel709 this PR needs updating because it does not compile. |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 108 tests passed 🎉Pipeline on Agent XAMBOT-1098.BigSur' |
There were a few changes in the headers that I believe are not bound by us: