New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MediaPlayer] Add Support for DotNet Attributes #12538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results4 tests failed, 104 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small fixes with the strings, great work!
src/MediaPlayer/MPVolumeSettings.cs
Outdated
#else | ||
[UnsupportedOSPlatform ("ios11.3")] | ||
#if IOS | ||
[Obsolete ("Starting with ios11.3 Use 'MPVolumeView' to present volume controls.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowe case use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I thought this looked a little fishy too haha I'll change those!
src/MediaPlayer/MPVolumeSettings.cs
Outdated
#else | ||
[UnsupportedOSPlatform ("ios11.3")] | ||
#if IOS | ||
[Obsolete ("Starting with ios11.3 Use 'MPVolumeView' to present volume controls.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
src/MediaPlayer/MPVolumeSettings.cs
Outdated
#else | ||
[UnsupportedOSPlatform ("ios11.3")] | ||
#if IOS | ||
[Obsolete ("Starting with ios11.3 Use 'MPVolumeView' to present volume controls.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
#else | ||
[UnsupportedOSPlatform ("ios15.0")] | ||
#if IOS | ||
[Obsolete ("Starting with ios15.0 The iAd framework has been removed from iOS.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lower case 'The'
👀 |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results25 tests failed, 83 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 108 tests passed 🎉Pipeline on Agent XAMBOT-1106.BigSur' |
No description provided.