[ci] Opt in to symbol archiving during VS insertion #12547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results39 tests failed, 108 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
rolfbjarne
approved these changes
Aug 26, 2021
| @@ -78,4 +78,11 @@ stages: | |||
| - template: vs-insertion/stage/v1.yml@templates | |||
| parameters: | |||
| dependsOn: prepare_release | |||
| symbolArtifactName: nuget-signed | |||
| symbolArtifactPatterns: | | |||
| Microsoft.NET.Sdk.iOS.Manifest*.nupkg | |||
There was a problem hiding this comment.
Does it fail if any of these patterns result in no files matched? If it doesn't, it might be a good idea to add all our nupkgs here, for all platforms, just in case they're ever added to Windows (one less place to remember to add something if we ever decide to). tvOS for instance is likely to be added at some point.
There was a problem hiding this comment.
This same pattern is used during the msi generation step to make sure the VS manifests we generate contain the right set of installers. We could try to consolidate this to one list or make the filter more flexible in the future once it needs to change.
chamons
approved these changes
Aug 26, 2021
emaf
approved these changes
Aug 26, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 144 tests passed.Failed tests
Pipeline on Agent XAMBOT-1108.BigSur' |
|
Test failures are unrelated:
|
|
/sudo backport release/6.0.1xx-rc.1 |
|
Backport Job to branch release/6.0.1xx-rc.1 Created! The magic is happening here |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5141252 for more details. |
pjcollins
added a commit
to pjcollins/xamarin-macios
that referenced
this pull request
Aug 27, 2021
Context: xamarin/yaml-templates#131 Enables conversion and archiving of symbol files during the VS insertion stage. Symbol archiving steps will only run if both the `symbolArtifactName` parameter is provided, and `archiveSymbols` is set to true. The `symbolConversionFilters` parameter can be used to filter out paths of symbol files that should not be converted/archived. Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
dalexsoto
added a commit
that referenced
this pull request
Aug 29, 2021
Context: xamarin/yaml-templates#131 Enables conversion and archiving of symbol files during the VS insertion stage. Symbol archiving steps will only run if both the `symbolArtifactName` parameter is provided, and `archiveSymbols` is set to true. The `symbolConversionFilters` parameter can be used to filter out paths of symbol files that should not be converted/archived. Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: Alex Soto <alex@alexsoto.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/yaml-templates/pull/131
Enables conversion and archiving of symbol files during the VS insertion
stage. Symbol archiving steps will only run if both the
symbolArtifactNameparameter is provided, andarchiveSymbolsis setto true. The
symbolConversionFiltersparameter can be used to filterout paths of symbol files that should not be converted/archived.