[AVFoundation] Add support for xcode 13 beta 5. #12550

mandel-macaque · 2021-08-25T19:39:29Z

Only new types/struct have the new attrs to simplify the review else we had too many additions (was done and reverted).

chamons · 2021-08-25T19:44:40Z

src/avfoundation.cs

+		[Async]
+		[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
+		[Export ("loadChapterMetadataGroupsBestMatchingPreferredLanguages:completionHandler:")]
+		void LoadChapterMetadataGroups (string[] preferredLanguages, Action<NSArray<AVTimedMetadataGroup>, NSError> completionHandler);


The BestMatching got dropped here, thoughts?

For that matter, I'd add the language to in the name of the method.

In doubt double check with the swift name -> loadChapterMetadataGroups
but the first argument is bestMatchingPreferredLanguages
https://developer.apple.com/documentation/avfoundation/avasset/3746525-loadchaptermetadatagroups

chamons · 2021-08-25T19:44:59Z

src/avfoundation.cs

+
+		[NoWatch, NoTV, NoiOS, Mac (12, 0), MacCatalyst (15,0)]
+		[Field ("AVFileTypeAppleiTT")]
+		AppleiTT = 21,


iTT looks weird but I think it's right?!

Not english, so I went for the name from apple

The UTI for the Apple iTT caption file format => The value of this UTI is com.apple.itunes-timed-text. Files of this type have an .itt extension.

chamons · 2021-08-25T19:50:16Z

src/avfoundation.cs

+	[DisableDefaultCtor]
+	interface AVPlaybackCoordinator
+	{
+


Nit: extra line

chamons · 2021-08-25T19:51:15Z

src/avfoundation.cs

+
+		[NoMacCatalyst]
+		[Export ("captionsNotPresentInPreviousGroupsInCaptionGroup:")]
+		AVCaption[] GetCaptionsNotPresent (AVCaptionGroup captionGroup);


Name dropped "inPrevious", maybe arg should be named prevousCaptionGroup?

I think I should add the full name.

yep, GetCaptionsNotPresentInPreviousGroups

chamons · 2021-08-25T19:53:45Z

I've been out of the game for awhile, so get another set of 👀 before landing.

vs-mobiletools-engineering-service2 · 2021-08-25T20:06:19Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 1a970ff into f0373ee

spouliot · 2021-08-25T21:16:28Z

src/AVFoundation/AVTypes.cs

+		static extern AVCaptionDimension AVCaptionDimensionMake (nfloat dimension, AVCaptionUnitsType units);
+
+		public static AVCaptionDimension Create (nfloat dimension, AVCaptionUnitsType units)
+			=> AVCaptionDimensionMake  (dimension, units);


you can merge both by using EntryPoint = "AVCaptionDimensionMake" on the DllImport (it reduce metadata)

Because it's a [Native] enum in the signature, you still need the wrapper function.

@rolfbjarne so I did right, correct? (might have been pure luck, but nobody knows)

good point for this p/invoke
however the other ones can still be simplified

spouliot · 2021-08-25T21:16:39Z

src/AVFoundation/AVTypes.cs

+		static extern AVCaptionPoint AVCaptionPointMake (AVCaptionDimension x, AVCaptionDimension y);
+
+		public static AVCaptionPoint Create (AVCaptionDimension x, AVCaptionDimension y)
+			=> AVCaptionPointMake (x,y);


spouliot · 2021-08-25T21:16:48Z

src/AVFoundation/AVTypes.cs

+		static extern AVCaptionSize AVCaptionSizeMake (AVCaptionDimension width, AVCaptionDimension height);
+
+		public static AVCaptionSize Create (AVCaptionDimension width, AVCaptionDimension height)
+			=> AVCaptionSizeMake (width, height);


spouliot · 2021-08-25T21:24:13Z

src/AVFoundation/Enums.cs

+#if !NET
+	[iOS (15,0), TV (15,0), Watch (8,0), Mac (10,10), MacCatalyst (15,0)]
+#else
+	[SupportedOSPlatform ("ios15.0"), SupportedOSPlatform ("tvos15.0"), SupportedOSPlatform ("macos10.10"), SupportedOSPlatform ("maccatalyst15.0")]


[SupportedOSPlatform ("macos10.10")] should not be needed since the assembly sets the minimum to 10.14
We should add some (NET specific) tests for that.

still present
not a big deal since, iirc, the generator will just ignore it since this is a processed file

AVFOUNDATION_API_SOURCES = \ AVFoundation/Enums.cs \

which also means it did not require any availability changes ;-)

src/AVFoundation/Enums.cs

src/avfoundation.cs

spouliot · 2021-08-25T21:46:36Z

src/avfoundation.cs

+	{
+		[Static]
+		[Export ("appleITTTopRegion")]
+		AVCaptionRegion AppleITTTopRegion { get; }


If it's the same iTT as above, it should be AppleiTTTopRegion...

Is the same iTT, it stands I believe for iTunes Timed Text

it's a 3 letters acronym so it would be Itt

spouliot · 2021-08-25T21:46:59Z

src/avfoundation.cs

+
+		[Static]
+		[Export ("appleITTBottomRegion")]
+		AVCaptionRegion AppleITTBottomRegion { get; }


spouliot · 2021-08-25T21:47:09Z

src/avfoundation.cs

+
+		[Static]
+		[Export ("appleITTLeftRegion")]
+		AVCaptionRegion AppleITTLeftRegion { get; }


spouliot · 2021-08-25T21:47:18Z

src/avfoundation.cs

+
+		[Static]
+		[Export ("appleITTRightRegion")]
+		AVCaptionRegion AppleITTRightRegion { get; }


vs-mobiletools-engineering-service2 · 2021-08-25T23:59:39Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

24 tests failed, 84 tests passed.

Failed tests

introspection/Mac Modern/Debug: BuildFailure
introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 39 Inconclusive: 0 Failed: 1 Ignored: 4)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
framework-test/Mac Modern/Debug: BuildFailure
framework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
framework-test/tvOS - simulator/Debug: BuildFailure
framework-test/watchOS 32-bits - simulator/Debug: BuildFailure
xcframework-test/Mac Modern/Debug: BuildFailure
xcframework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
xcframework-test/tvOS - simulator/Debug: BuildFailure
xcframework-test/watchOS 32-bits - simulator/Debug: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): BuildFailure
monotouch-test/tvOS - simulator/Debug: BuildFailure
monotouch-test/tvOS - simulator/Debug (LinkSdk): BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug: BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): BuildFailure
MSBuild tests/Integration: Failed (Execution failed with exit code 50)

Pipeline on Agent XAMBOT-1097.BigSur'
Merge aaa698a into f0373ee

rolfbjarne

Also missing tests for the manual bindings (P/Invokes).

src/AVFoundation/AVTypes.cs

rolfbjarne · 2021-08-26T11:46:51Z

src/AVFoundation/AVTypes.cs

+		static extern AVCaptionDimension AVCaptionDimensionMake (nfloat dimension, AVCaptionUnitsType units);
+
+		public static AVCaptionDimension Create (nfloat dimension, AVCaptionUnitsType units)
+			=> AVCaptionDimensionMake  (dimension, units);


Because it's a [Native] enum in the signature, you still need the wrapper function.

src/AVFoundation/AVTypes.cs

rolfbjarne · 2021-08-26T11:57:22Z

src/avfoundation.cs

+
+		[NoWatch, NoTV, NoiOS, Mac (12, 0), MacCatalyst (15,0)]
+		[Field ("AVFileTypeAppleiTT")]
+		AppleiTT = 21,


The UTI for the Apple iTT caption file format => The value of this UTI is com.apple.itunes-timed-text. Files of this type have an .itt extension.

src/avfoundation.cs

rolfbjarne · 2021-08-26T12:18:49Z

src/avfoundation.cs

+	{
+		[Static]
+		[Export ("appleITTTopRegion")]
+		AVCaptionRegion AppleITTTopRegion { get; }


If it's the same iTT as above, it should be AppleiTTTopRegion...

vs-mobiletools-engineering-service2 · 2021-08-26T23:26:35Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 106 tests passed.

Failed tests

introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 39 Inconclusive: 0 Failed: 1 Ignored: 4)
introspection/iOS Unified 64-bits - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 1ee4425 into cf491b0

src/AVFoundation/AVTypes.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

…e/xamarin-macios into avfoundation-xcode13-beta5

vs-mobiletools-engineering-service2 · 2021-08-28T00:49:39Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 106 tests passed.

Failed tests

introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 39 Inconclusive: 0 Failed: 1 Ignored: 4)
introspection/iOS Unified 64-bits - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge b1dcdac into 11838db

src/AVFoundation/Enums.cs

src/avfoundation.cs

spouliot · 2021-08-30T19:20:34Z

src/avfoundation.cs

+	{
+		[Static]
+		[Export ("appleITTTopRegion")]
+		AVCaptionRegion AppleiTTTopRegion { get; }


-> AppleIttTopRegion(even the selector name uses an uppercaseI` here)

spouliot · 2021-08-30T19:20:40Z

src/avfoundation.cs

+
+		[Static]
+		[Export ("appleITTBottomRegion")]
+		AVCaptionRegion AppleiTTBottomRegion { get; }


spouliot · 2021-08-30T19:20:47Z

src/avfoundation.cs

+
+		[Static]
+		[Export ("appleITTLeftRegion")]
+		AVCaptionRegion AppleiTTLeftRegion { get; }


spouliot · 2021-08-30T19:20:55Z

src/avfoundation.cs

+
+		[Static]
+		[Export ("appleITTRightRegion")]
+		AVCaptionRegion AppleiTTRightRegion { get; }


vs-mobiletools-engineering-service2 · 2021-08-30T21:12:35Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 105 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2642 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 151)
dont link/Mac Catalyst/Debug [dotnet]: Failed (Test run crashed (exit code: 134).
Tests run: 11 Passed: 6 Inconclusive: 0 Failed: 0 Ignored: 5)
introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 39 Inconclusive: 0 Failed: 1 Ignored: 4)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 4d54edf into 69cf276

tj-devel709 · 2021-08-31T00:39:59Z

src/avfoundation.cs

+		AVCoordinatedPlaybackSuspension BeginSuspension (string suspensionReason);
+
+		[Export ("expectedItemTimeAtHostTime:")]
+		CMTime ExpectedItemTimeAtHostTime (CMTime hostClockTime);


Suggested change

CMTime ExpectedItemTimeAtHostTime (CMTime hostClockTime);

CMTime GetExpectedItemTime (CMTime hostClockTime);

Perhaps verb-ify and remove suffix

tj-devel709 · 2021-08-31T00:44:02Z

src/avfoundation.cs

+		AVCaptionRegion AppleiTTLeftRegion { get; }
+
+		[Static]
+		[Export ("appleITTRightRegion")]


Maybe not anything but, for me, Github shows the color of the code only being black from this point on. Is there perhaps a syntax thing going on somewhere?

No, is that the file is too long and probably the js is not dealing with it.

vs-mobiletools-engineering-service2 · 2021-08-31T21:11:37Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 108 tests passed 🎉

Pipeline on Agent XAMBOT-1099.BigSur'
Merge c0e1067 into 066d5b5

spouliot · 2021-09-01T20:16:37Z

src/avfoundation.cs

@@ -11381,14 +11381,17 @@ interface AVPlayerRateDidChangeEventArgs {
 		NSString RateDidChangeOriginatingParticipant { get; }
 	}

-	[iOS (10, 0), TV (10,0), Mac (10,12), MacCatalyst (15,0)]
+	[iOS (10, 0), TV (10,0), Mac (10,12), MacCatalyst (14,0)]


why 14,0 ? the oldest member is 14,5

spouliot · 2021-09-01T20:17:49Z

src/avfoundation.cs

+	{
+		[Static]
+		[Export ("appleITTTopRegion")]
+		AVCaptionRegion AppleITTTopRegion { get; }


it's a 3 letters acronym so it would be Itt

mandel-macaque · 2021-09-01T22:27:35Z

we need to get intro on monterey + catalyst to land this.

rolfbjarne · 2021-09-06T15:21:55Z

src/avfoundation.cs

@@ -3205,7 +3320,7 @@ interface AVFragmentedAssetMinder {
 	interface AVFragmentedAssetTrack {
 	}

-#if MONOMAC
+#if MONOMAC || __MACCATALYST__


Yes, just move the IAVCaptureFileOutputDelegate out of the #if MONOMAC block, that makes the code more obvious.

rolfbjarne · 2021-09-06T15:24:30Z

src/avfoundation.cs

 		[Export ("currentSampleAudioDependencyInfo")]
 		AVSampleCursorAudioDependencyInfo CurrentSampleAudioDependencyInfo { get; }
+
+		[NullAllowed]
+		[NoWatch, NoTV, NoiOS, Mac (12, 0), MacCatalyst (15,0)]


The type is already NoiOS, NoTV, NoWatch, so 3/5ths of this is not necessary.

The type is also MacCatalyst (15, 0), so there's another 1/5th which is unnecessary.

Same goes for the member just above.

That also means that the #if MONOMAC || __MACCATALYST__ condition can be completely removed.

rolfbjarne · 2021-09-06T15:30:22Z

src/avfoundation.cs

-#if MONOMAC
-		[Unavailable (PlatformName.MacCatalyst)]
+#if MONOMAC || __MACCATALYST__
+		[NoMacCatalyst]


You're adding || __MACCATALYST__ and then also adding [NoMacCatalyst].

In this case it's better to move the #endif further up (to not include the RecordingPaused property), and then add [NoiOS] on that property.

As long as reasonably possible, we should strive towards removing/reducing #if <platform> code, not make it more complex.

rolfbjarne · 2021-09-06T15:34:14Z

src/avfoundation.cs

+
+		[Export ("renditionSpecificAttributesForMediaOption:")]
+		[return: NullAllowed]
+		AVAssetVariantAudioRenditionSpecificAttributes GetRenditionSpecificAttributesForMediaOption (AVMediaSelectionOption mediaSelectionOption);


Suggested change

AVAssetVariantAudioRenditionSpecificAttributes GetRenditionSpecificAttributesForMediaOption (AVMediaSelectionOption mediaSelectionOption);

AVAssetVariantAudioRenditionSpecificAttributes GetRenditionSpecificAttributes (AVMediaSelectionOption mediaSelectionOption);

rolfbjarne · 2021-09-06T15:38:49Z

src/avfoundation.cs

+		[NullAllowed, Export ("identifier")]
+		string Identifier { get; }
+
+#if MONOMAC // needed because the structs are inside a #if too


You could do this at the top of the file:

#if !MONOMAC using AVCaptionPoint=Foundation.NSObject; ...

is a bunch of them...

vs-mobiletools-engineering-service2 · 2021-09-14T03:00:38Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 100 tests passed.

Failed tests

link sdk/tvOS - simulator/Debug: Failed
link sdk/tvOS - simulator/Release: Failed

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 9690ab2 into 1bacc4e

spouliot · 2021-09-14T15:15:26Z

src/AVFoundation/Enums.cs

+#if !NET
+	[iOS (15,0), TV (15,0), Watch (8,0), Mac (10,10), MacCatalyst (15,0)]
+#else
+	[SupportedOSPlatform ("ios15.0"), SupportedOSPlatform ("tvos15.0"), SupportedOSPlatform ("macos10.10"), SupportedOSPlatform ("maccatalyst15.0")]


still present
not a big deal since, iirc, the generator will just ignore it since this is a processed file

AVFOUNDATION_API_SOURCES = \ AVFoundation/Enums.cs \

which also means it did not require any availability changes ;-)

vs-mobiletools-engineering-service2 · 2021-09-15T00:06:05Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 100 tests passed.

Failed tests

link sdk/tvOS - simulator/Debug: Failed
link sdk/tvOS - simulator/Release: Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge de398b7 into 25c8099

mandel-macaque · 2021-09-15T15:37:00Z

Known issues: #12640

mandel-macaque · 2021-09-15T15:37:57Z

/sudo backport xcode13-ios

vs-mobiletools-engineering-service2 · 2021-09-15T15:38:21Z

Backport Job to branch xcode13-ios Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2021-09-15T15:39:26Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5207975 for more details.

[AVFoundation] Add support for xcdoe 13 beta 5.

1a970ff

mandel-macaque added the note-highlight Worth calling out specifically in release notes label Aug 25, 2021

mandel-macaque requested review from dalexsoto and spouliot as code owners August 25, 2021 19:39

chamons approved these changes Aug 25, 2021

View reviewed changes

mandel-macaque added 2 commits August 25, 2021 16:22

Add missing using.

87c642c

Generator crashes when we use support os with no version.

aaa698a

spouliot suggested changes Aug 25, 2021

View reviewed changes

rolfbjarne requested changes Aug 26, 2021

View reviewed changes

Address reviews.

1ee4425

rolfbjarne requested changes Aug 27, 2021

View reviewed changes

src/AVFoundation/AVTypes.cs Outdated Show resolved Hide resolved

src/AVFoundation/AVTypes.cs Outdated Show resolved Hide resolved

mandel-macaque and others added 5 commits August 27, 2021 11:06

Apply suggestions from code review

4fdca6e

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Update src/avfoundation.cs

adfeed7

Merge branch 'main' into avfoundation-xcode13-beta5

a320726

Merge branch 'avfoundation-xcode13-beta5' of github.com:mandel-macaqu…

bc8c875

…e/xamarin-macios into avfoundation-xcode13-beta5

Fix compilation after applying comments.

b1dcdac

Fix intro tests by removing not present selector.

4d54edf

spouliot reviewed Aug 30, 2021

View reviewed changes

tj-devel709 reviewed Aug 31, 2021

View reviewed changes

tj-devel709 approved these changes Aug 31, 2021

View reviewed changes

dalexsoto added this to August 2021 in Xcode 13 Aug 31, 2021

Address reviews.

c0e1067

spouliot changed the title ~~[AVFoundation] Add support for xcdoe 13 beta 5.~~ [AVFoundation] Add support for xcode 13 beta 5. Sep 1, 2021

spouliot suggested changes Sep 1, 2021

View reviewed changes

mandel-macaque added the do-not-merge Do not merge this pull request label Sep 1, 2021

rolfbjarne requested changes Sep 6, 2021

View reviewed changes

mandel-macaque added 7 commits September 8, 2021 17:30

Merge branch 'main' into avfoundation-xcode13-beta5

2f84fd6

Fix issue with the catalyst intro tests.

9457b4f

Merge branch 'main' into avfoundation-xcode13-beta5

5c7d5c3

Fix API after xtro was fixed.

ebf0fd3

Merge branch 'main' into avfoundation-xcode13-beta5

f8cd240

Address reviews.

b9c67d8

Simplify preprocessor #if

9690ab2

spouliot approved these changes Sep 14, 2021

View reviewed changes

mandel-macaque added 2 commits September 14, 2021 15:42

Merge branch 'main' into avfoundation-xcode13-beta5

656b890

Remove not needed attrs.

de398b7

rolfbjarne approved these changes Sep 15, 2021

View reviewed changes

mandel-macaque merged commit 124dc24 into xamarin:main Sep 15, 2021

	CMTime ExpectedItemTimeAtHostTime (CMTime hostClockTime);
	CMTime GetExpectedItemTime (CMTime hostClockTime);

	AVAssetVariantAudioRenditionSpecificAttributes GetRenditionSpecificAttributesForMediaOption (AVMediaSelectionOption mediaSelectionOption);
	AVAssetVariantAudioRenditionSpecificAttributes GetRenditionSpecificAttributes (AVMediaSelectionOption mediaSelectionOption);

[AVFoundation] Add support for xcode 13 beta 5. #12550

[AVFoundation] Add support for xcode 13 beta 5. #12550

Conversation

mandel-macaque commented Aug 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chamons commented Aug 25, 2021

vs-mobiletools-engineering-service2 commented Aug 25, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Aug 25, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

rolfbjarne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Aug 26, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Aug 28, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Aug 30, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Aug 31, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 108 tests passed 🎉

Choose a reason for hiding this comment

Choose a reason for hiding this comment