Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msbuild] Fixed the Inputs for the _CodesignAppBundle target #1438

Merged
merged 2 commits into from Jan 5, 2017

Conversation

jstedfast
Copy link
Member

The Inputs need to include the Info.plist, embedded.mobileprovision,
and the native libs/frameworks since those files also get included
in the _CodeSignature/CodeResources.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=50791

The Inputs need to include the Info.plist, embedded.mobileprovision,
and the native libs/frameworks since those files also get included
in the _CodeSignature/CodeResources.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=50791
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can one of the msbuild test be modified to check this ? e.g. build, change a build setting, and build again (without error)

@monojenkins
Copy link
Collaborator

Build failure

@jstedfast
Copy link
Member Author

@spouliot added

@monojenkins
Copy link
Collaborator

Build failure

@jstedfast
Copy link
Member Author

AFAICT the failure isn't related to msbuild

@jstedfast jstedfast merged commit 3103153 into master Jan 5, 2017
@jstedfast jstedfast deleted the msbuild-codesign-bundle branch January 5, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants