[msbuild/dotnet] Add support for passing --aot arguments to the AOT compiler. #14936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompiler. Pick up --aot arguments in MtouchExtraArgs and pass them to the AOT compiler when building a .NET project. This makes it possible to work around xamarin#14887 by manually increasing the number of trampolines. Ref: xamarin#14887
rolfbjarne
added
not-notes-worthy
📚 [CI Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent XAMBOT-1017.Monterey |
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌Failed tests are:
Pipeline on Agent |
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1098.Monterey' |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
chamons
approved these changes
May 9, 2022
tj-devel709
approved these changes
May 9, 2022
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results18 tests failed, 131 tests passed.Failed tests
Pipeline on Agent XAMBOT-1035.Monterey |
dalexsoto
approved these changes
May 9, 2022
|
Test failures are all network related (https://github.com/xamarin/maccore/issues/1067). |
mauroa
approved these changes
May 10, 2022
emaf
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick up --aot arguments in MtouchExtraArgs and pass them to the AOT compiler
when building a .NET project. This makes it possible to work around #14887 by
manually increasing the number of trampolines.
Ref: #14887