Resource files for mac should be copied to the app bundle #1500
Conversation
| Directory.CreateDirectory (target_dir); | ||
|
|
||
| CopyAssembly (a, target_s); | ||
| } |
There was a problem hiding this comment.
That's a copy of the same method in tools/common/Assembly.cs. The code should be moved into tools/common/Assembly.cs which is where the shared mtouch/mmp code aside.
|
Build failure |
2 similar comments
|
Build failure |
|
Build failure |
|
Build |
|
Build failure |
| @@ -1700,6 +1700,8 @@ static void CopyI18nAssemblies (I18nAssemblies i18n) | |||
|
|
|||
| // The linker later gets angry if you copy in a read only assembly | |||
| CopyFileAndRemoveReadOnly (asm, Path.Combine (mmp_dir, filename)); | |||
| foreach (var assembly in BuildTarget.Assemblies) | |||
There was a problem hiding this comment.
You're iterating over all the assemblies inside a foreach of all the assemblies. Shouldn't this new foreach be placed outside the containing foreach?
|
monotouch-test has tests for this, but iirc they were not ported to XM. It would be nice to get those tests working on XM as well. |
|
Build failure |
|
@timrisi Can you merge in master and see what we need to get this in? |
|
Build failure |
|
Build failure |
|
Build failure |
|
Failures unrelated (media player made 64-bit, handled in a separate PR) |
For https://bugzilla.xamarin.com/show_bug.cgi?id=45696
Resource files are compiled into the bin folder but not copied into the actual app folder currently. This copies them to where they need to be.