[CloudKit] Update bindings for Xcode 14 beta 1and2 #15546

tj-devel709 · 2022-07-19T16:54:21Z

No description provided.

…Beta1and2

dalexsoto · 2022-07-20T13:45:09Z

src/cloudkit.cs

+
+	[TV (16,0), NoWatch, Mac (13,0), iOS (16,0), MacCatalyst (16,0)]
+	[BaseType (typeof (NSObject))]
+	interface CKAllowedSharingOptions : NSSecureCoding, NSCopying


I think this needs a [DisableDefaultCtor] since there is a native ctor

Suggested change

interface CKAllowedSharingOptions : NSSecureCoding, NSCopying

[DisableDefaultCtor]

interface CKAllowedSharingOptions : NSSecureCoding, NSCopying

dalexsoto · 2022-07-20T13:46:11Z

src/cloudkit.cs

+		NativeHandle Constructor (CKContainer container);
+
+		[NullAllowed, Export ("systemSharingUIDidSaveShareBlock", ArgumentSemantic.Copy)]
+		Action<CKRecordID, CKShare, NSError> SystemSharingUIDidSaveShareBlock { get; set; }


Suggested change

Action<CKRecordID, CKShare, NSError> SystemSharingUIDidSaveShareBlock { get; set; }

Action<CKRecordID, CKShare, NSError> SystemSharingUIDidSaveShareHandler { get; set; }

dalexsoto · 2022-07-20T13:46:28Z

src/cloudkit.cs

+		Action<CKRecordID, CKShare, NSError> SystemSharingUIDidSaveShareBlock { get; set; }
+
+		[NullAllowed, Export ("systemSharingUIDidStopSharingBlock", ArgumentSemantic.Copy)]
+		Action<CKRecordID, NSError> SystemSharingUIDidStopSharingBlock { get; set; }


Suggested change

Action<CKRecordID, NSError> SystemSharingUIDidStopSharingBlock { get; set; }

Action<CKRecordID, NSError> SystemSharingUIDidStopSharingHandler { get; set; }

dalexsoto · 2022-07-20T13:48:33Z

src/foundation.cs

+
+		// extension methods from CloudKit
+
+		[Async]


This async looks like may be troublesome, it is not a completion handler but a preparation handler we do not know when this is called so I would remove the Async here

Suggested change

[Async]

Agreed, does look like it will be execute before anything happens, that means that if we callout async we would have a completely wrong behaviour.

dalexsoto

Oops, wrong option selected ^ :P

mandel-macaque · 2022-07-20T16:34:46Z

src/CloudKit/Enums.cs

+	{
+		ReadOnly = 1uL << 0,
+		ReadWrite = 1uL << 1,
+		Any = ReadOnly | ReadWrite


nit, missing comma.

Suggested change

Any = ReadOnly | ReadWrite

Any = ReadOnly | ReadWrite,

mandel-macaque · 2022-07-20T16:35:29Z

src/cloudkit.cs

+	}
+
+	[NoWatch, NoTV, Mac (13,0), iOS (16,0), MacCatalyst (16,0)]
+	delegate void CKSharePreparationHandler ();


Why not just use Action?

mandel-macaque · 2022-07-20T16:35:56Z

src/foundation.cs

+		[Async]
+		[NoWatch, NoTV, Mac (13,0), iOS (16,0), MacCatalyst (16,0)]
+		[Export ("registerCKShareWithContainer:allowedSharingOptions:preparationHandler:")]
+		void RegisterCKShare (CKContainer container, CKAllowedSharingOptions allowedOptions, CKSharePreparationHandler preparationHandler);


Suggested change

void RegisterCKShare (CKContainer container, CKAllowedSharingOptions allowedOptions, CKSharePreparationHandler preparationHandler);

void RegisterCKShare (CKContainer container, CKAllowedSharingOptions allowedOptions, Action preparationHandler);

mandel-macaque · 2022-07-20T16:36:43Z

src/foundation.cs

+
+		// extension methods from CloudKit
+
+		[Async]


Agreed, does look like it will be execute before anything happens, that means that if we callout async we would have a completely wrong behaviour.

…Beta1and2

tj-devel709 · 2022-07-22T23:22:40Z

@dalexsoto @mandel-macaque Requested changes addressed!

tj-devel709 · 2022-07-25T16:31:00Z

Xtro passes locally, so run tests again

tj-devel709 · 2022-07-25T16:31:07Z

/azp run

azure-pipelines · 2022-07-25T16:31:47Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2022-07-25T18:09:07Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 6a4de6c23f0b60deebb469fbec5129a240ce5c11 [PR build]

vs-mobiletools-engineering-service2 · 2022-07-25T18:15:54Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 6a4de6c23f0b60deebb469fbec5129a240ce5c11 [PR build]

vs-mobiletools-engineering-service2 · 2022-07-25T18:20:36Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1171.Monterey'
Hash: 6a4de6c23f0b60deebb469fbec5129a240ce5c11 [PR build]

vs-mobiletools-engineering-service2 · 2022-07-25T19:01:49Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

xammac_tests
monotouch-test

Pipeline on Agent
Hash: 6a4de6c23f0b60deebb469fbec5129a240ce5c11 [PR build]

vs-mobiletools-engineering-service2 · 2022-07-25T21:08:21Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 3 tests failed, 225 tests passed.

Failures

❌ cecil tests

1 tests failed, 0 tests passed.

Cecil-based tests/NUnit: Failed (Execution failed with exit code 3)

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ xtro tests

1 tests failed, 1 tests passed.

Xtro/Legacy Xamarin: Failed (Test run failed.)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

mandel-macaque

xtrotests are unrelated, cecil tests are known: https://github.com/xamarin/maccore/issues/2607

TJ Lambert added 3 commits July 7, 2022 15:21

starting CloudKit

f4cdeb3

Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-CloudKit-…

218ebf0

…Beta1and2

move the category methods to the baseclass

9165f68

tj-devel709 added the notes-mention Deserves a mention in release notes label Jul 19, 2022

tj-devel709 added this to the xcode14 milestone Jul 19, 2022

tj-devel709 requested review from rolfbjarne, chamons and mandel-macaque as code owners July 19, 2022 16:54

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jul 20, 2022

View reviewed changes

dalexsoto requested changes Jul 20, 2022

View reviewed changes

mandel-macaque requested changes Jul 20, 2022

View reviewed changes

TJ Lambert added 2 commits July 22, 2022 17:17

address pr changes

d1b77c8

Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-CloudKit-…

6a4de6c

…Beta1and2

This comment has been minimized.

Sign in to view

mandel-macaque approved these changes Jul 26, 2022

View reviewed changes

dalexsoto approved these changes Jul 26, 2022

View reviewed changes

mandel-macaque merged commit ffcdcc1 into xamarin:xcode14 Jul 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CloudKit] Update bindings for Xcode 14 beta 1and2 #15546

[CloudKit] Update bindings for Xcode 14 beta 1and2 #15546

tj-devel709 commented Jul 19, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto Jul 20, 2022

dalexsoto Jul 20, 2022

dalexsoto Jul 20, 2022

dalexsoto Jul 20, 2022

mandel-macaque Jul 20, 2022

dalexsoto left a comment

mandel-macaque Jul 20, 2022

mandel-macaque Jul 20, 2022

mandel-macaque Jul 20, 2022

mandel-macaque Jul 20, 2022

tj-devel709 commented Jul 22, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 commented Jul 25, 2022

tj-devel709 commented Jul 25, 2022

azure-pipelines bot commented Jul 25, 2022

vs-mobiletools-engineering-service2 commented Jul 25, 2022

vs-mobiletools-engineering-service2 commented Jul 25, 2022

vs-mobiletools-engineering-service2 commented Jul 25, 2022

vs-mobiletools-engineering-service2 commented Jul 25, 2022

vs-mobiletools-engineering-service2 commented Jul 25, 2022

mandel-macaque left a comment •

edited

	interface CKAllowedSharingOptions : NSSecureCoding, NSCopying
	[DisableDefaultCtor]
	interface CKAllowedSharingOptions : NSSecureCoding, NSCopying

	Action<CKRecordID, CKShare, NSError> SystemSharingUIDidSaveShareBlock { get; set; }
	Action<CKRecordID, CKShare, NSError> SystemSharingUIDidSaveShareHandler { get; set; }

	Action<CKRecordID, NSError> SystemSharingUIDidStopSharingBlock { get; set; }
	Action<CKRecordID, NSError> SystemSharingUIDidStopSharingHandler { get; set; }

	void RegisterCKShare (CKContainer container, CKAllowedSharingOptions allowedOptions, CKSharePreparationHandler preparationHandler);
	void RegisterCKShare (CKContainer container, CKAllowedSharingOptions allowedOptions, Action preparationHandler);

[CloudKit] Update bindings for Xcode 14 beta 1and2 #15546

[CloudKit] Update bindings for Xcode 14 beta 1and2 #15546

Conversation

tj-devel709 commented Jul 19, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dalexsoto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tj-devel709 commented Jul 22, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 commented Jul 25, 2022

tj-devel709 commented Jul 25, 2022

azure-pipelines bot commented Jul 25, 2022

vs-mobiletools-engineering-service2 commented Jul 25, 2022

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Jul 25, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

vs-mobiletools-engineering-service2 commented Jul 25, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Jul 25, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

vs-mobiletools-engineering-service2 commented Jul 25, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ cecil tests

❌ introspection tests

❌ xtro tests

Successes

mandel-macaque left a comment • edited

Choose a reason for hiding this comment

mandel-macaque left a comment •

edited