Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HealthKit] Update bindings for Xcode 14 beta 1-4 #15612

Merged
merged 26 commits into from Sep 1, 2022
Merged

[HealthKit] Update bindings for Xcode 14 beta 1-4 #15612

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
850ff73
starting HealthKit Beta1and3 Xcode 14
Jul 25, 2022
c47a80f
Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-HealthKit…
Jul 28, 2022
991ef06
starting HealthKit Xcode 14 bindings
Aug 1, 2022
8483bca
Add a disableDefaultCtor
Aug 1, 2022
af68016
fix the p-invoke manual code and test
Aug 3, 2022
00f8c76
Few extra MacCatalyst things but most were already implemented
Aug 3, 2022
b5577c0
Merge branch 'xcode14' into Xcode14-HealthKit-Beta1and3
tj-devel709 Aug 3, 2022
2d76b02
directly use appkit on mac
Aug 3, 2022
80653c0
Merge remote-tracking branch 'TJ/Xcode14-HealthKit-Beta1and3' into Xc…
Aug 3, 2022
af6759e
add radar issue with iOS attribute - fix cecil error
Aug 4, 2022
7347553
Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-HealthKit…
Aug 4, 2022
e23f581
Merge branch 'xcode14' into Xcode14-HealthKit-Beta1and3
dalexsoto Aug 5, 2022
73128a7
Merge branch 'xcode14' into Xcode14-HealthKit-Beta1and3
dalexsoto Aug 10, 2022
3ed801c
[HealtKit] Fix intro, monotouch and xammac
dalexsoto Aug 11, 2022
8e8d9fb
[HomeKit] Fix GetAsleepValuesTest on old OS Versions
dalexsoto Aug 11, 2022
da44626
[HealthKit] Fix remaining tests
dalexsoto Aug 11, 2022
a45bd43
Merge branch 'xcode14' into Xcode14-HealthKit-Beta1and3
tj-devel709 Aug 16, 2022
3a239b7
Address Rolf's suggestions
Aug 17, 2022
e7497bb
fix failing tests
Aug 18, 2022
85280de
address suggestions - use strong types and fix names
Aug 22, 2022
b02c179
add a using statement and spacing
Aug 24, 2022
e5789d8
Merge branch 'xcode14' into Xcode14-HealthKit-Beta1and3
tj-devel709 Aug 24, 2022
957ffc1
Add Delegates for stronger array types and names
Aug 26, 2022
3dbf734
there were compiler issues with these nullallowed
Aug 27, 2022
82af5b6
Merge remote-tracking branch 'TJ/Xcode14-HealthKit-Beta1and3' into Xc…
Aug 27, 2022
7975c6e
Merge branch 'xcode14' into Xcode14-HealthKit-Beta1and3
tj-devel709 Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/healthkit.cs
View file
Open in desktop
Expand Up @@ -564,7 +564,7 @@ interface HKCorrelationType {

delegate void HKHealthStoreGetRequestStatusForAuthorizationToShareHandler (HKAuthorizationRequestStatus requestStatus, NSError error);
delegate void HKHealthStoreRecoverActiveWorkoutSessionHandler (HKWorkoutSession session, NSError error);
delegate void HKHealthStoreCompletionHandler (bool success, [NullAllowed] NSError error);
delegate void HKHealthStoreCompletionHandler (bool success, NSError error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird... what was the compiler issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up @SotoiGhost !
Here is a gist of the errors / warnings that were not present when not including the [NullAllowed]
https://gist.github.com/tj-devel709/756ac73e32f3ff8ae234d8ba7ecdd7cc


[Watch (2,0)]
[iOS (8,0)]
Expand Down Expand Up @@ -4212,7 +4212,7 @@ interface HKAttachment : NSSecureCoding, NSCopying
NSDictionary<NSString, NSObject> Metadata { get; }
}

delegate void HKAttachmentStoreCompletionHandler (bool success, [NullAllowed] NSError error);
delegate void HKAttachmentStoreCompletionHandler (bool success, NSError error);
delegate void HKAttachmentStoreDataHandler ([NullAllowed] NSData dataChunk, [NullAllowed] NSError error, bool done);
delegate void HKAttachmentStoreGetAttachmentCompletionHandler ([NullAllowed] HKAttachment[] attachments, [NullAllowed] NSError error);

Expand Down