Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoreFoundation] Add deprecation and ignores for Xcode 14 Beta 1-5 #15799

Merged
merged 1 commit into from Aug 31, 2022
Merged

[CoreFoundation] Add deprecation and ignores for Xcode 14 Beta 1-5 #15799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/CoreFoundation/CFStream.cs
View file
Open in desktop
Expand Up @@ -464,7 +464,10 @@ public abstract class CFStream : CFType {
[SupportedOSPlatform ("tvos")]
[UnsupportedOSPlatform ("macos10.11")]
[UnsupportedOSPlatform ("ios9.0")]
#if MONOMAC
[UnsupportedOSPlatform ("tvos9.0")]
#if TVOS
[Obsolete ("Starting with tvos9.0.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#elif MONOMAC
[Obsolete ("Starting with macos10.11.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#elif IOS
[Obsolete ("Starting with ios9.0.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
Expand Down Expand Up @@ -510,7 +513,10 @@ public static CFHTTPStream CreateForHTTPRequest (CFHTTPMessage request)
[SupportedOSPlatform ("tvos")]
[UnsupportedOSPlatform ("macos10.11")]
[UnsupportedOSPlatform ("ios9.0")]
#if MONOMAC
[UnsupportedOSPlatform ("tvos9.0")]
#if TVOS
[Obsolete ("Starting with tvos9.0.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#elif MONOMAC
[Obsolete ("Starting with macos10.11.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
#elif IOS
[Obsolete ("Starting with ios9.0.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]
Expand Down
4 changes: 3 additions & 1 deletion tests/xtro-sharpie/api-annotations-dotnet/common-CoreFoundation.ignore
View file
Open in desktop
Expand Up @@ -8,7 +8,9 @@
!missing-field! kCFURLVolumeAvailableCapacityForImportantUsageKey not bound
!missing-field! kCFURLVolumeAvailableCapacityForOpportunisticUsageKey not bound


## variable argument and string manipulation more easily done in C#
!missing-pinvoke! CFStringCreateStringWithValidatedFormat is not bound
!missing-pinvoke! CFStringCreateStringWithValidatedFormatAndArguments is not bound
Comment on lines +11 to +13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have support for variadics arguments in C/Objc APIs: https://en.cppreference.com/w/cpp/language/variadic_arguments


## unsorted

Expand Down
2 changes: 0 additions & 2 deletions tests/xtro-sharpie/api-annotations-dotnet/iOS-CoreFoundation.todo
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tests/xtro-sharpie/api-annotations-dotnet/macOS-CoreFoundation.todo
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions tests/xtro-sharpie/api-annotations-dotnet/tvOS-CoreFoundation.todo
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions tests/xtro-sharpie/common-CoreFoundation.ignore
View file
Open in desktop
Expand Up @@ -8,6 +8,9 @@
!missing-field! kCFURLVolumeAvailableCapacityForImportantUsageKey not bound
!missing-field! kCFURLVolumeAvailableCapacityForOpportunisticUsageKey not bound

## variable argument and string manipulation more easily done in C#
!missing-pinvoke! CFStringCreateStringWithValidatedFormat is not bound
!missing-pinvoke! CFStringCreateStringWithValidatedFormatAndArguments is not bound


## unsorted
Expand Down
2 changes: 0 additions & 2 deletions tests/xtro-sharpie/iOS-CoreFoundation.todo
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tests/xtro-sharpie/macOS-CoreFoundation.todo
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tests/xtro-sharpie/tvOS-CoreFoundation.todo
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tests/xtro-sharpie/watchOS-CoreFoundation.todo
View file
Open in desktop

This file was deleted.