[CoreGraphics] Xcode 14 Beta 1-5 #15831

chamons · 2022-08-31T15:57:22Z

Note: This PR is almost entirely of manual (but simple) bindings, and the documentation of these CG methods is non-existent. I had to add add MarshalAs and change pointers to IntPtr by hand, so please review carefully.

I wrote "did not crash/return null" manual tests, which I could improve upon if desired, but I'd have to re-learn some matrix math and figure out what each method does under the hood (Alex thought this would likely be fine).

A few important notes:

CGAffineTransformComponents is in CoreFoundation as it was defined (but not used) in those API diffs. There is a define CF_DEFINES_CGAFFINETRANSFORMCOMPONENTS which allows CoreGraphics to declare it in the headers, but I'm assuming that is a hack for Apple.
The headers/docs for kCGColorSpaceITUR_709_HLG lie and claim it's in older OS than it seems to be, so I assumed latest instead.

src/CoreGraphics/CGPDFScanner.cs

src/CoreGraphics/CGPath.cs

src/coregraphics.cs

tests/monotouch-test/CoreGraphics/AffineTransformTest.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

tj-devel709 · 2022-09-01T15:00:10Z

src/CoreFoundation/CGAffineTransformComponents.cs

+	[SupportedOSPlatform ("maccatalyst")]
+	[SupportedOSPlatform ("macos")]
+	[SupportedOSPlatform ("tvos")]
+#endif


Is this struct only available in NET?

No, but we don't add attributes to structs in legacy usually. We have a test that insists we do in NET6.

tj-devel709 · 2022-09-01T15:03:48Z

src/CoreGraphics/CGPDFScanner.cs

+#endif
+		public void Stop ()
+		{
+			CGPDFScannerStop (Handle);


Just curious, I see in other methods as well that there is a "Handle" var, where is it coming from?

NSObject.Handle

tj-devel709

Left a few questions, but LGTM

chamons · 2022-09-01T21:11:12Z

Looking at test failures here in xammac tests/monotouch test.

vs-mobiletools-engineering-service2 · 2022-09-01T23:29:53Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 41ad7aae081aad399c6645227da5777f83f4197e [PR build]

vs-mobiletools-engineering-service2 · 2022-09-01T23:31:21Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 41ad7aae081aad399c6645227da5777f83f4197e [PR build]

vs-mobiletools-engineering-service2 · 2022-09-01T23:43:00Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1173.Monterey'
Hash: 41ad7aae081aad399c6645227da5777f83f4197e [PR build]

vs-mobiletools-engineering-service2 · 2022-09-02T00:00:53Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

introspection
xammac_tests
monotouch-test

Pipeline on Agent
Hash: 41ad7aae081aad399c6645227da5777f83f4197e [PR build]

vs-mobiletools-engineering-service2 · 2022-09-02T02:46:14Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 2 tests failed, 226 tests passed.

Failures

❌ framework tests

1 tests failed, 7 tests passed.

framework-test/watchOS 32-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

chamons · 2022-09-02T14:23:49Z

Test failures are watch only.

[CoreGraphics] Xcode 14 Beta 1-5

927bf46

chamons added the notes-mention Deserves a mention in release notes label Aug 31, 2022

chamons requested review from dalexsoto and mandel-macaque August 31, 2022 15:57

chamons requested a review from rolfbjarne as a code owner August 31, 2022 15:57

rolfbjarne requested changes Aug 31, 2022

View reviewed changes

src/CoreGraphics/CGPDFScanner.cs Outdated Show resolved Hide resolved

src/CoreGraphics/CGPath.cs Show resolved Hide resolved

src/coregraphics.cs Outdated Show resolved Hide resolved

tests/monotouch-test/CoreGraphics/AffineTransformTest.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

chamons and others added 3 commits August 31, 2022 14:53

Update src/coregraphics.cs

ba866f5

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Fix attribute mistakes

4333c40

Update test

54a4065

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Sep 1, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Sep 1, 2022

View reviewed changes

tj-devel709 reviewed Sep 1, 2022

View reviewed changes

tj-devel709 approved these changes Sep 1, 2022

View reviewed changes

mandel-macaque approved these changes Sep 1, 2022

View reviewed changes

Fix monotouch-test

41ad7aa

chamons merged commit e43e05c into xamarin:xcode14 Sep 2, 2022

chamons deleted the xcode14_coregraphics branch September 2, 2022 14:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CoreGraphics] Xcode 14 Beta 1-5 #15831

[CoreGraphics] Xcode 14 Beta 1-5 #15831

chamons commented Aug 31, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 Sep 1, 2022

chamons Sep 1, 2022

tj-devel709 Sep 1, 2022

chamons Sep 1, 2022

tj-devel709 left a comment

chamons commented Sep 1, 2022

vs-mobiletools-engineering-service2 commented Sep 1, 2022

vs-mobiletools-engineering-service2 commented Sep 1, 2022

vs-mobiletools-engineering-service2 commented Sep 1, 2022

vs-mobiletools-engineering-service2 commented Sep 2, 2022

vs-mobiletools-engineering-service2 commented Sep 2, 2022

chamons commented Sep 2, 2022

[CoreGraphics] Xcode 14 Beta 1-5 #15831

[CoreGraphics] Xcode 14 Beta 1-5 #15831

Conversation

chamons commented Aug 31, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 Sep 1, 2022

Choose a reason for hiding this comment

chamons Sep 1, 2022

Choose a reason for hiding this comment

tj-devel709 Sep 1, 2022

Choose a reason for hiding this comment

chamons Sep 1, 2022

Choose a reason for hiding this comment

tj-devel709 left a comment

Choose a reason for hiding this comment

chamons commented Sep 1, 2022

vs-mobiletools-engineering-service2 commented Sep 1, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

vs-mobiletools-engineering-service2 commented Sep 1, 2022

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Sep 1, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Sep 2, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

vs-mobiletools-engineering-service2 commented Sep 2, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ framework tests

❌ introspection tests

Successes

chamons commented Sep 2, 2022