[net7.0] [workload] Update net6.0 KnownFrameworkReference #15882
Conversation
A `Xamarin.Shared.Sdk.MultiTarget.targets` file has been added to update the ref/runtime pack versions associated with the .NET 6 SDK. This file will only be imported when using the .NET 6 SDK, and it should work around the need to add new net6 and net7 versioned aliases of the Ref and Runtime packs. Adding this file to `AfterMicrosoftNETSdkTargets` will ensure that it is imported last, after all KnownFrameworkReferences that need updating are declared.
vs-mobiletools-engineering-service2
requested a review
from rolfbjarne
as a code owner
Commit 53766eb attempted to remove all references to the `Ref` and `Runtime` packs that had a `.net7` alias, however one instance in the workload manifest was missed.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…kload that wants to reference more than one set of ref/runtime packs.
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Tests timed out Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
.NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 🎉 All 220 tests passed 🎉 Failures❌ msbuild tests🔥 Failed catastrophically on VSTS: simulator tests - msbuild (no summary found). Html Report (VSDrops) Download ❌ mtouch tests🔥 Failed catastrophically on VSTS: simulator tests - mtouch (no summary found). Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
/sudo backport release/7.0.1xx-rc2 |
|
/sudo backport release/7.0.1xx-xcode14-rc2 |
|
Backport Job to branch release/7.0.1xx-xcode14-rc2 Created! The magic is happening here |
|
Backport Job to branch release/7.0.1xx-rc2 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6741166 for more details. |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6741167 for more details. |
…FrameworkReference (#16135) A `Xamarin.Shared.Sdk.MultiTarget.targets` file has been added to update the ref/runtime pack versions associated with the .NET 6 SDK. This file will ship as part of the .NET 7 SDK but only be imported when using the .NET 6 SDK. This should work around the need to add new and net7 versioned aliases of the `Ref` and `Runtime` packs. Adding this file to `AfterMicrosoftNETSdkTargets` will ensure that it is imported last, after all `KnownFrameworkReferences` that need updating are declared. Backport of #15834 Backport of #15882 Co-authored-by: Peter Collins <pecolli@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
…kReference (#16136) A `Xamarin.Shared.Sdk.MultiTarget.targets` file has been added to update the ref/runtime pack versions associated with the .NET 6 SDK. This file will ship as part of the .NET 7 SDK but only be imported when using the .NET 6 SDK. This should work around the need to add new and net7 versioned aliases of the `Ref` and `Runtime` packs. Adding this file to `AfterMicrosoftNETSdkTargets` will ensure that it is imported last, after all `KnownFrameworkReferences` that need updating are declared. Backport of #15834 Backport of #15882 Co-authored-by: Peter Collins <pecolli@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
A
Xamarin.Shared.Sdk.MultiTarget.targetsfile has been added to updatethe ref/runtime pack versions associated with the .NET 6 SDK. This file
will ship as part of the .NET 7 SDK but only be imported when using the
.NET 6 SDK. This should work around the need to add new and net7
versioned aliases of the
RefandRuntimepacks. Adding this file toAfterMicrosoftNETSdkTargetswill ensure that it is imported last,after all
KnownFrameworkReferencesthat need updating are declared.Backport of #15834