[CoreMotion] Updates for Xcode14.0.0 #15977

tj-devel709 · 2022-09-15T19:09:29Z

No description provided.

…amarin#15649)" Apple removed this framework from Xcode 14 RC This reverts commit d9cd069.

…json. Also move bash code from yml to a .sh file for easier reading, writing and debugging.

…enabled.

Fix parsing WorkloadRollback.json to not throw an error if an entry doesn't exist: Select-Object: /Users/builder/azdo/_work/_temp/7602a64f-206e-4a71-b5f3-f55f2812ad0c.ps1:13 Line | 13 | … versionData | Select-Object -ExpandProperty "microsoft.net.sdk.macos" | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | Property "microsoft.net.sdk.macos" cannot be found.

…nt build.

Doing a merge commit for this PR so we can revert the revert in the future for BackgroundAssets * Apple removed BackgroundAssets * Apple removed macOS 13.0 SDK * Apple Removed MacCat 16.0 SDK

…n-rc

rolfbjarne · 2022-09-16T13:14:25Z

src/coremotion.cs

+
+		[Abstract]
+		[Export ("manager:errorOccurred:")]
+		void DidErrorOccurred (CMWaterSubmersionManager manager, NSError error);


Suggested change

void DidErrorOccurred (CMWaterSubmersionManager manager, NSError error);

void ErrorOccurred (CMWaterSubmersionManager manager, NSError error);

@rolfbjarne This one was originally "ErrorOccurred" but I attempted to Verbify it. Perhaps "DidErrorOccured" would have been better but I'm curious why to use "ErrorOccurred" here

Mostly because that's what the selector says. I also thought about DidErrorOccur, but that's pretty much the same as ErrorOccurred, and in that case I prefer whatever the selector says to make things easier.

chamons

Approved conditionally with fixing Rolf's comment.

vs-mobiletools-engineering-service2 · 2022-09-16T17:56:14Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

No test package could be found for tests on macOS M1 - Mac Big Sur (11.5)

Pipeline on Agent
Hash: b9508e732920536ad515d4bc53cf1a1a11aac734 [PR build]

vs-mobiletools-engineering-service2 · 2022-09-16T17:56:45Z

❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌

No test package could be found for tests on macOS Mac Catalina (10.15)

Pipeline on Agent
Hash: b9508e732920536ad515d4bc53cf1a1a11aac734 [PR build]

vs-mobiletools-engineering-service2 · 2022-09-16T18:19:57Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1180.Monterey'
Hash: b9508e732920536ad515d4bc53cf1a1a11aac734 [PR build]

vs-mobiletools-engineering-service2 · 2022-09-16T18:23:35Z

🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent
Hash: b9508e732920536ad515d4bc53cf1a1a11aac734 [PR build]

vs-mobiletools-engineering-service2 · 2022-09-16T22:14:55Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 12 tests failed, 148 tests passed.

Failures

❌ monotouch tests

12 tests failed, 8 tests passed.

monotouch-test/tvOS - simulator/Debug [dotnet]: Failed
monotouch-test/tvOS - simulator/Debug: Failed
monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: Failed
monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: Failed
monotouch-test/tvOS - simulator/Release (all optimizations) [dotnet]: Failed
monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed
monotouch-test/tvOS - simulator/Debug (static registrar): Failed
monotouch-test/tvOS - simulator/Release (all optimizations): Failed
monotouch-test/watchOS 32-bits - simulator/Debug: TimedOut
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Failed
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed

Html Report (VSDrops) Download

Successes

✅ bcl: All 59 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 5 tests passed. Html Report (VSDrops) Download
✅ framework: All 5 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 5 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 5 tests passed. Html Report (VSDrops) Download
✅ linker: All 38 tests passed. Html Report (VSDrops) Download
⚠️ mac_binding_project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
✅ mononative: All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. Html Report (VSDrops) Download
✅ xcframework: All 5 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

tj-devel709 · 2022-09-19T15:25:46Z

Closing here, will open up a PR into the Xcode14.1 branch

dalexsoto and others added 23 commits September 7, 2022 19:57

Revert "[BackgroundAssets] Add new framework from Xcode1 4 beta 4. (x…

b0203d7

…amarin#15649)" Apple removed this framework from Xcode 14 RC This reverts commit d9cd069.

[xcode14] Bump to Xcode 14 RC

d428810

Fix intro tests

66fbeef

Merge remote-tracking branch 'xamarin/xcode14' into xcode14-rc-bump

9a6cae9

Remove not needed BackgroundAssets.todo

c7c2ed0

[devops] Work around the fact that macOS is disabled in this branch.

1102c78

[devops] More fixes for missing (as expected) Xamarin.Mac.

031410f

[devops] Only add platforms we're building for into WorkloadRollback.…

e70d077

…json. Also move bash code from yml to a .sh file for easier reading, writing and debugging.

Xcode 14 RC 1 requires macOS 12.5.

eba9544

[devops] Fix typo in bash script.

7435d8a

[devops] Don't create legacy iOS/Mac symlinks unless legacy build is …

2ef695d

…enabled.

Merge remote-tracking branch 'origin/xcode14' into xcode14-rc-bump

77dd98c

Merge branch 'xcode14' into xcode14-rc-bump

00b3705

Bump to stable Xcode 14

4c90a7f

[devops] Fix json syntax.

6f8d821

Fix xtro.

bb9eb0a

[tests] Ignore tests that require platforms not included in the curre…

6df6207

…nt build.

Merge remote-tracking branch 'origin/xcode14' into xcode14-rc-bump

a2f89bd

[xcode14] Bump to Xcode 14 (xamarin#15898)

c629dd8

Doing a merge commit for this PR so we can revert the revert in the future for BackgroundAssets * Apple removed BackgroundAssets * Apple removed macOS 13.0 SDK * Apple Removed MacCat 16.0 SDK

Xcode 14 rc updates

4918e08

Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-CoreMotio…

3b65e24

…n-rc

use empty interface

b9508e7

tj-devel709 added the notes-mention Deserves a mention in release notes label Sep 15, 2022

tj-devel709 added this to the xcode14 milestone Sep 15, 2022

tj-devel709 marked this pull request as ready for review September 15, 2022 19:09

stephen-hawley approved these changes Sep 15, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Sep 16, 2022

View reviewed changes

chamons approved these changes Sep 16, 2022

View reviewed changes

mandel-macaque approved these changes Sep 16, 2022

View reviewed changes

tj-devel709 changed the base branch from xcode14 to xcode14.1 September 16, 2022 16:45

tj-devel709 closed this Sep 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CoreMotion] Updates for Xcode14.0.0 #15977

[CoreMotion] Updates for Xcode14.0.0 #15977

tj-devel709 commented Sep 15, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Sep 16, 2022

tj-devel709 Sep 16, 2022

rolfbjarne Sep 16, 2022

chamons left a comment

vs-mobiletools-engineering-service2 commented Sep 16, 2022

vs-mobiletools-engineering-service2 commented Sep 16, 2022

vs-mobiletools-engineering-service2 commented Sep 16, 2022

vs-mobiletools-engineering-service2 commented Sep 16, 2022

vs-mobiletools-engineering-service2 commented Sep 16, 2022

tj-devel709 commented Sep 19, 2022

	void DidErrorOccurred (CMWaterSubmersionManager manager, NSError error);
	void ErrorOccurred (CMWaterSubmersionManager manager, NSError error);

[CoreMotion] Updates for Xcode14.0.0 #15977

[CoreMotion] Updates for Xcode14.0.0 #15977

Conversation

tj-devel709 commented Sep 15, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Sep 16, 2022

Choose a reason for hiding this comment

tj-devel709 Sep 16, 2022

Choose a reason for hiding this comment

rolfbjarne Sep 16, 2022

Choose a reason for hiding this comment

chamons left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Sep 16, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

vs-mobiletools-engineering-service2 commented Sep 16, 2022

❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌

vs-mobiletools-engineering-service2 commented Sep 16, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Sep 16, 2022

vs-mobiletools-engineering-service2 commented Sep 16, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ monotouch tests

Successes

tj-devel709 commented Sep 19, 2022