Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] [mtouch] Automatically disable bitcode if using Xcode 14+. Fixes #15210. #16054

Merged
merged 5 commits into from
Sep 22, 2022
Merged

[main] [mtouch] Automatically disable bitcode if using Xcode 14+. Fixes #15210. #16054

merged 5 commits into from
Sep 22, 2022

Commits on Sep 21, 2022

  1. [mtouch] Automatically disable bitcode if using Xcode 14+. Fixes xama… 

    …rin#15210.

Apple has deprecated bitcode, and will apparently reject app submissions
containing bitcode starting with Xcode 14. So automatically disable bitcode if
building using Xcode 14+ (and show a warning so that app developers can remove
the 'MtouchEnableBitcode' property from their project files).

Fixes xamarin#15210.
    @rolfbjarne
    rolfbjarne authored and vs-mobiletools-engineering-service2 committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    c103564 View commit details
    Browse the repository at this point in the history

  2. Change logic a bit. 

    watchOS will now compile for bitcode + native code, then remove bitcode, since
the AOT compiler doesn't like building just native code.
    @rolfbjarne
    rolfbjarne authored and vs-mobiletools-engineering-service2 committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    df17cf3 View commit details
    Browse the repository at this point in the history

  3. [tests] Improve assertion message for mtouch tests.

    @rolfbjarne
    rolfbjarne authored and vs-mobiletools-engineering-service2 committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    fa1c758 View commit details
    Browse the repository at this point in the history

  4. A few adjustments.

    @rolfbjarne
    rolfbjarne authored and vs-mobiletools-engineering-service2 committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    69d1c8e View commit details
    Browse the repository at this point in the history

  5. [tests] Fix test scenario when using Xcode 13 or earlier.

    @rolfbjarne
    rolfbjarne committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    aff8f7d View commit details
    Browse the repository at this point in the history