-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msbuild] Fix parsing -gcc_flags when the value is the next argument. Fixes #16861. #16862
[msbuild] Fix parsing -gcc_flags when the value is the next argument. Fixes #16861. #16862
Conversation
…ixes xamarin#16861. The -gcc_flags in the extra mtouch/mmp arguments can either be of the format '-gcc_flags=<value>' or '-gcc_flags <value>'. Previously we only parsed the former correctly, and now fix the parsing logic to handle the latter version correctly as well. Fixes xamarin#16861.
|
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)✅ Generator diffGenerator diff is empty Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
The -gcc_flags in the extra mtouch/mmp arguments can either be of the format
'-gcc_flags=' or '-gcc_flags '. Previously we only parsed the
former correctly, and now fix the parsing logic to handle the latter version
correctly as well.
Fixes #16861.