[dotnet] Cache the AOT compiler path. Fixes #16774. #17033
Conversation
Cache the AOT compiler path, to avoid an expensive recomputation on every build. This is even more expensive when building remotely from Windows, so store the cached value on Windows. Fixes xamarin#16774.
rolfbjarne
requested review from
jonathanpeppers,
mauroa,
emaf and
dellis1972
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent XAMBOT-1023.Monterey' |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)✅ Generator diffGenerator diff is empty Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
| Condition="Exists('$(_AotCompilerCachePath)')" | ||
| File="$(_AotCompilerCachePath)" | ||
| > | ||
| <Output TaskParameter="Lines" PropertyName="_AOTCompiler" /> |
There was a problem hiding this comment.
The only thing I would suggest, is $(_AOTCompiler) might collide with someone else trying to use the same name? Something in the .NET SDK or Mono workload.
In Android, I would name it $(_AndroidAOTCompiler) to avoid that, so I don't know if you normally use Apple as a prefix or something else.
There was a problem hiding this comment.
I'll do that in a different PR.
Use a more unique property name than _AOTCompiler (use _XamarinAOTCompiler instead) to try to prevent any problems if somebody else tries to use '_AOTCompiler' somewhere. Ref: xamarin#17033 (comment)
…17049) Use a more unique property name than _AOTCompiler (use _XamarinAOTCompiler instead) to try to prevent any problems if somebody else tries to use '_AOTCompiler' somewhere. Ref: #17033 (comment)
Cache the AOT compiler path, to avoid an expensive recomputation on every
build. This is even more expensive when building remotely from Windows, so
store the cached value on Windows.
Fixes #16774.