Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] sanitized pinvokes that use string #17143

Merged
merged 4 commits into from
Jan 11, 2023
Merged

[dotnet] sanitized pinvokes that use string #17143

merged 4 commits into from
Jan 11, 2023

Conversation

stephen-hawley
Copy link
Contributor

sanitized the pinvokes that use string.
Note: I did not address the pinvokes that take callback functions - that will be addressed in a later PR.

@stephen-hawley stephen-hawley added the dotnet An issue or pull request related to .NET (6) label Jan 4, 2023
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
rolfbjarne
rolfbjarne requested changes Jan 9, 2023
View reviewed changes
src/CoreFoundation/Dispatch.cs Outdated
@@ -556,11 +556,16 @@ public DispatchQualityOfService GetQualityOfService (out int relative_priority)
}
}

static IntPtr dispatch_queue_create_wrapper (string label, IntPtr attr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NBD, but I think this should work due to method overloading:

Suggested change
static IntPtr dispatch_queue_create_wrapper (string label, IntPtr attr)
static IntPtr dispatch_queue_create (string label, IntPtr attr)

src/CoreFoundation/CFString.cs Outdated
@@ -146,7 +146,8 @@ public static NativeHandle CreateNative (string? value)
if (value is null)
return NativeHandle.Zero;

return CFStringCreateWithCharacters (IntPtr.Zero, value, value.Length);
using var valuePtr = new TransientString (value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CFStringCreateWithCharacters takes a Unicode string:

Suggested change
using var valuePtr = new TransientString (value);
using var valuePtr = new TransientString (value, TransientString.Encoding.Unicode);

src/CoreFoundation/CFString.cs Show resolved Hide resolved
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: a9be272f538feea12a2591afe1bc2ec96eb1d9c7 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent XAMBOT-1107.Monterey'
Hash: a9be272f538feea12a2591afe1bc2ec96eb1d9c7 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: a9be272f538feea12a2591afe1bc2ec96eb1d9c7 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: a9be272f538feea12a2591afe1bc2ec96eb1d9c7 [PR build]

@stephen-hawley stephen-hawley merged commit 553904d into xamarin:main Jan 11, 2023
@stephen-hawley stephen-hawley deleted the pinvokes-core-foundation branch January 11, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees
No one assigned
Labels
dotnet An issue or pull request related to .NET (6)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephen-hawley @vs-mobiletools-engineering-service2 @rolfbjarne