Added GPSLatitudeRef and GPSLongitudeRef to CGImagePropertiesGPS. #17166

dustin-wojciechowski · 2023-01-10T04:57:20Z

Figured I would take a stab at this. Since these are properties and the underlying functions are tested in DictionaryPickerTest, I didn't write any tests. I can if that is desired though.

Note: There is a TODO section that implies that more properties should be brought into the class... is that something I should add in as well?

tipa · 2023-01-10T05:17:32Z

I think the types for LatitudeRef & LongitudeRef should be string and not float, right?

rolfbjarne

Figured I would take a stab at this. Since these are properties and the underlying functions are tested in DictionaryPickerTest, I didn't write any tests. I can if that is desired though.

I think a test would be a good idea, because:

Note: There is a TODO section that implies that more properties should be brought into the class... is that something I should add in as well?

Yes, that would be nice. Note that the problem is figuring out which type to expose (neither Apple's documentation nor headers seem to be particularly useful) - which is why a test would be useful.

The same can also be said for the other custom dictionaries in this file (CGImagePropertiesExif, CGImagePropertiesTiff, CGImagePropertiesJfif, CGImagePropertiesPng, CGImagePropertiesIptc)

mandel-macaque

+1 as long as @rolfbjarne comments are taken into account and at test is added.

dalexsoto

Looking good, +1 on the test

github-actions · 2023-01-12T18:36:21Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

dustin-wojciechowski · 2023-01-12T18:42:27Z

I added a test for the properties. Should these additional properties be assigned their own separate issue?

src/CoreGraphics/CGImageProperties.cs

tests/monotouch-test/CoreGraphics/CGImagePropertiesGPSTest.cs

rolfbjarne · 2023-01-13T12:06:53Z

Should these additional properties be assigned their own separate issue?

Yes, that's probably the simplest.

tests/monotouch-test/CoreGraphics/CGImagePropertiesGPSTest.cs

github-actions · 2023-01-19T22:21:58Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

dustin-wojciechowski · 2023-01-19T22:43:28Z

Additional properties have been assigned their own issue: #17315

…as still linking to non-loc version of image file. Found some more instances where new file needs to be added.

github-actions · 2023-01-25T19:42:14Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

…thin dotnet tests.

…rtiesgps-17162

vs-mobiletools-engineering-service2 · 2023-01-27T20:47:09Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 68a9b041684e905acb21db5e884112f6b1aa719f [PR build]

vs-mobiletools-engineering-service2 · 2023-01-27T20:53:39Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 68a9b041684e905acb21db5e884112f6b1aa719f [PR build]

vs-mobiletools-engineering-service2 · 2023-01-27T21:12:10Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1044.Monterey'
Hash: 68a9b041684e905acb21db5e884112f6b1aa719f [PR build]

vs-mobiletools-engineering-service2 · 2023-01-28T00:02:23Z

🔥 Failed to compute test summaries on VSTS: simulator tests 🔥

Failed to compute test summaries:

TF24668: The following team project collection is stopped: devdiv. Start the collection and then try again. Administrator Reason: Applying Split DB to account

    body {
        font-family: "-apple-system",BlinkMacSystemFont,"Segoe UI",Roboto,"Helvetica Neue",Helvetica,Ubuntu,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";
        font-size: 14px;
        height: 100%;
        margin: 0;
        background-color: #fff;
    }

    A {
        color: #007ACC;
        text-decoration: none;
    }
    A:hover {
        text-decoration: underline;
    }

    .header {
        background-color: #0078d4;
        color: #fff;
        height: 40px;
        font-size: 14px;
    }

    .header .logo {
        height: 20px;
        margin: 9px 5px 0 9px;
    }

    .header .product-name {
        vertical-align: top;
        padding-top: 10px;
        display: inline-block;
    }

    .content {
        margin-left: 15%;
        margin-right: 5%;
    }

    .error-summary {
        margin-bottom: 40px;
    }

    .error-code {
        display: inline-block;
        vertical-align: top;
        color: #777;
        font-size: 200px;
        line-height: 130px;
        margin-top: 60px;
        margin-right: 40px;
    }

    .error-details {
        display: inline-block;
        vertical-align: top;
        margin-top: 60px;
        max-width: 500px;
    }

    .error-details > h1 {
        font-size: 28px;
        margin: 0;
        text-transform:uppercase;
        font-weight:normal;
    }
    .error-details > h3 {
        text-transform: uppercase;
        font-size: 16px;
    }

    .error-details .action {
        font-size: 16px;
    }

    .error-details .action-text {
        vertical-align: middle;
    }

    .error-details > .helpful-links > a {
        margin-right: 10px;
    }

    .more-info {
        min-width:600px;
    }

    .more-info > pre {
        margin: 20px 0;
        white-space: pre-wrap;
    }

    .tips, .additionalDetails {
        min-width:500px;
        margin: 40px 0;
    }

    .tips > ul {
        list-style-type: square;
    }

    .tips > ul > li {
        margin-bottom: 10px;
    }

    .additionalDetails > h3 {
        font-size: 16px;
        font-weight: normal;
    }

    .additionalDetails .title {
        font-weight: bold;
        color: #444;
    }

    .additionalDetails .info {
        color: #777;
    }

    .additionalDetails > div {
        margin-top: 5px;
        margin-left: 20px;
    }




    
    Azure DevOps Services


    
        503
        
            Service Unavailable
            
            We are currently unavailable
            
                
                    View our service status updates
                
            
            
                Service Status and Support
                @AzureDevOps
            
        
    

    
    
        More information about this error
        TF24668: The following team project collection is stopped: devdiv. Start the collection and then try again. Administrator Reason: Applying Split DB to account

        
    
    



    function getError() {
        return "eyJVcmkiOiJodHRwczovL2RldmRpdi52aXN1YWxzdHVkaW8uY29tOjQ0My9EZXZEaXYvX2FwaXMvYnVpbGQvYnVpbGRzLzcyNTA2Nzg/YXBpLXZlcnNpb249Ni4wIiwiU3RhdHVzQ29kZSI6NTAzLCJNZXNzYWdlIjoiVEYyNDY2ODogVGhlIGZvbGxvd2luZyB0ZWFtIHByb2plY3QgY29sbGVjdGlvbiBpcyBzdG9wcGVkOiBkZXZkaXYuIFN0YXJ0IHRoZSBjb2xsZWN0aW9uIGFuZCB0aGVuIHRyeSBhZ2Fpbi4gQWRtaW5pc3RyYXRvciBSZWFzb246IEFwcGx5aW5nIFNwbGl0IERCIHRvIGFjY291bnQiLCJEZXRhaWxzIjoiIiwiQ29udGVudCI6bnVsbCwiSWRlbnRpdHkiOiIifQ==";
    }

    try {
        if (typeof window.external !== "undefined" && typeof window.external.notifyError !== "undefined") {
            window.external.notifyError(getError());
        }
        else if (typeof window.notifyError !== "undefined") {
            window.notifyError(getError());
        }
    }
    catch (x) {
        document.write("" + x + "");
    }

.

Pipeline on Agent
Merge 68a9b04 into 3f4ce6c

vs-mobiletools-engineering-service2 · 2023-01-28T17:23:56Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 68a9b041684e905acb21db5e884112f6b1aa719f [PR build]

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Jan 10, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque approved these changes Jan 10, 2023

View reviewed changes

dalexsoto reviewed Jan 12, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Jan 13, 2023

View reviewed changes

src/CoreGraphics/CGImageProperties.cs Outdated Show resolved Hide resolved

tests/monotouch-test/CoreGraphics/CGImagePropertiesGPSTest.cs Outdated Show resolved Hide resolved

tests/monotouch-test/CoreGraphics/CGImagePropertiesGPSTest.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

haritha-mohan reviewed Jan 14, 2023

View reviewed changes

tests/monotouch-test/CoreGraphics/CGImagePropertiesGPSTest.cs Outdated Show resolved Hide resolved

dustin-wojciechowski requested review from emaf and mauroa as code owners January 19, 2023 19:29

dustin-wojciechowski force-pushed the add-latituderef-longituderef-to-cgimagepropertiesgps-17162 branch from c861282 to 94423d7 Compare January 19, 2023 22:17

dustin-wojciechowski mentioned this pull request Jan 19, 2023

Add More tests for CGImageProperties #17315

Open

dustin-wojciechowski requested a review from rolfbjarne January 20, 2023 00:04

This comment has been minimized.

Sign in to view

dustin-wojciechowski force-pushed the add-latituderef-longituderef-to-cgimagepropertiesgps-17162 branch 2 times, most recently from a8dfe74 to e0a999e Compare January 24, 2023 18:17

This comment has been minimized.

Sign in to view

rolfbjarne force-pushed the add-latituderef-longituderef-to-cgimagepropertiesgps-17162 branch from e0a999e to 115c588 Compare January 25, 2023 06:39

This comment has been minimized.

Sign in to view

dustin-wojciechowski and others added 2 commits January 25, 2023 11:38

Updated more csproj files with new image file. Fixed instance where w…

20d6a2f

…as still linking to non-loc version of image file. Found some more instances where new file needs to be added.

Auto-format source code

a347872

This comment has been minimized.

Sign in to view

Changed order of items in resources group in ProjectTest unit test wi…

ac51d0d

…thin dotnet tests.

This comment has been minimized.

Sign in to view

Merge branch 'main' into add-latituderef-longituderef-to-cgimageprope…

68a9b04

…rtiesgps-17162

dustin-wojciechowski merged commit 51bee95 into xamarin:main Jan 28, 2023

dustin-wojciechowski deleted the add-latituderef-longituderef-to-cgimagepropertiesgps-17162 branch January 28, 2023 17:31

Added GPSLatitudeRef and GPSLongitudeRef to CGImagePropertiesGPS. #17166

Added GPSLatitudeRef and GPSLongitudeRef to CGImagePropertiesGPS. #17166

Conversation

dustin-wojciechowski commented Jan 10, 2023

tipa commented Jan 10, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment

Choose a reason for hiding this comment

This comment has been minimized.

mandel-macaque left a comment

Choose a reason for hiding this comment

dalexsoto left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 12, 2023

⚠️ Your code has been reformatted. ⚠️

dustin-wojciechowski commented Jan 12, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Jan 13, 2023

This comment has been minimized.

github-actions bot commented Jan 19, 2023

⚠️ Your code has been reformatted. ⚠️

dustin-wojciechowski commented Jan 19, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 25, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 27, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

vs-mobiletools-engineering-service2 commented Jan 27, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Jan 27, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Jan 28, 2023

🔥 Failed to compute test summaries on VSTS: simulator tests 🔥

vs-mobiletools-engineering-service2 commented Jan 28, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts