-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] CoreFont delegates #17338
[dotnet] CoreFont delegates #17338
Conversation
[DllImport (Constants.CoreTextLibrary)] | ||
static extern IntPtr CTFontCollectionCreateMatchingFontDescriptorsSortedWithCallback ( | ||
IntPtr collection, CTFontCollectionSortDescriptorsCallback sortCallback, IntPtr refCon); | ||
#endif | ||
|
||
delegate CFIndex CTFontCollectionSortDescriptorsCallback (IntPtr first, IntPtr second, IntPtr refCon); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: we don't need this delegate declaration in .NET anymore, so it can be inside #if !NET
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
failure looks like it is related to the csharp process not existing and reaching a task timeout in the ci, we should rerun it. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
70516d0
to
bc2a06f
Compare
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
For these set of changes, I'm converting a delegate type to
delegate* unmanaged<....>
and where necessary adding in the[UnmanagedCallersOnly]
attribute.