-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Generator] Move away from the generator-* pattern and use bgen src #17426
[Generator] Move away from the generator-* pattern and use bgen src #17426
Conversation
A clean up is needed in the generator. We have src/bgen. We can use it to move all the generator code there and make or work easier moving fwd.
src/bgen/bgen.csproj
Outdated
@@ -27,16 +27,6 @@ | |||
</None> | |||
<Compile Include="$(RepositoryPath)\src\btouch.cs" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can move btouch.cs
as well.
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
A clean up is needed in the generator. We have src/bgen. We can use it to move all the generator code there and make or work easier moving fwd.