Encode the .NET version we're targeting in the third NuGet version number. #17818
Conversation
…mber. Encode the .NET version we're targeting in the third NuGet version number by adding X000 (where X is the .NET version) to the commit distance. This accomplishes a few goals: * We automatically compute a different NuGet version depending on the .NET version we're targeting. * Versions are sorted correctly (.NET 7 nugets have a higher version number than .NET 6 nugets). * It's possible to see which .NET version a NuGet is targeting from the version. The downside is: * The scheme breaks down if we need more than three digits for the commit distance (possible solution: add another zero, so we add X0000 instead of X000).
|
@dalexsoto I think we'll need this for Xcode 14.3, otherwise we'll have to hardcode values to bump the version number for each release branch. |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Encode the .NET version we're targeting in the third NuGet version number by
adding X000 (where X is the .NET version) to the commit distance.
This accomplishes a few goals:
The downside is:
distance (possible solution: add another zero, so we add X0000 instead of
X000).