Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Verify Mac Catalyst apps like we verify macOS apps. Fixes #17829. #17835

Merged
merged 2 commits into from
Mar 21, 2023
Merged

[msbuild] Verify Mac Catalyst apps like we verify macOS apps. Fixes #17829. #17835

merged 2 commits into from
Mar 21, 2023

Conversation

rolfbjarne
Copy link
Member

Submission test is added as well:

Fixes #17829.

@rolfbjarne
[msbuild] Verify Mac Catalyst apps like we verify macOS apps. Fixes x…
35f2ca4 
…amarin#17829.

* For Mac Catalyst apps we must verify the code signature like we do it for
  macOS apps. Fixes xamarin#17829.
* Enable nullability and fix code accordingly.
* Merge the CodesignVerify and CodesignVerifyTaskBase classes to simplify the
  code.

Submission test is added as well:

* xamarin/maccore#2656
* xamarin/SubmissionSamples#51

Fixes xamarin#17829.
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Mar 17, 2023
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-015.Ventura
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: cbfbc4f6e6db6393be1d6322fe765dd917241c7a [PR build]

@rolfbjarne rolfbjarne merged commit bfd87e4 into xamarin:main Mar 21, 2023
@rolfbjarne rolfbjarne deleted the issue-17829 branch March 21, 2023 17:20
@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.2xx

@rolfbjarne
Copy link
Member Author

/sudo backport release/6.0.4xx-xcode14.2

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx Created! The magic is happening here

@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.1xx-xcode14.2

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx-xcode14.2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.1xx-xcode14.2 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7503768 for more details.

This was referenced Mar 21, 2023
Merged
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7503770 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7503772 for more details.

rolfbjarne added a commit that referenced this pull request Mar 22, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/6.0.4xx-xcode14.2] [msbuild] Verify Mac Catalyst apps like w…
dd38806 
…e verify macOS apps. Fixes #17829. (#17868)

* For Mac Catalyst apps we must verify the code signature like we do it for
  macOS apps. Fixes #17829.
* Enable nullability and fix code accordingly.
* Merge the CodesignVerify and CodesignVerifyTaskBase classes to simplify the
  code.

Submission test is added as well:

* xamarin/maccore#2656
* xamarin/SubmissionSamples#51

Fixes #17829.

Backport of #17835

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne pushed a commit that referenced this pull request Mar 22, 2023
@vs-mobiletools-engineering-service2
[release/7.0.2xx] [msbuild] Verify Mac Catalyst apps like we verify m…
15c7939 
…acOS apps. Fixes #17829. (#17867)

* For Mac Catalyst apps we must verify the code signature like we do it for
  macOS apps. Fixes #17829.
* Enable nullability and fix code accordingly.
* Merge the CodesignVerify and CodesignVerifyTaskBase classes to simplify the
  code.

Submission test is added as well:

* xamarin/maccore#2656
* xamarin/SubmissionSamples#51

Fixes #17829.


Backport of #17835
rolfbjarne pushed a commit that referenced this pull request Mar 22, 2023
@vs-mobiletools-engineering-service2
[release/7.0.1xx-xcode14.2] [msbuild] Verify Mac Catalyst apps like w…
875f44c 
…e verify macOS apps. Fixes #17829. (#17869)

* For Mac Catalyst apps we must verify the code signature like we do it for
  macOS apps. Fixes #17829.
* Enable nullability and fix code accordingly.
* Merge the CodesignVerify and CodesignVerifyTaskBase classes to simplify the
  code.

Submission test is added as well:

* xamarin/maccore#2656
* xamarin/SubmissionSamples#51

Fixes #17829.

Backport of #17835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@emaf emaf emaf approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

@haritha-mohan haritha-mohan haritha-mohan approved these changes

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

Assignees
No one assigned
Labels
bug If an issue is a bug or a pull request a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_CodesignVerify target fails when publishing a .NET MAUI MacCat app for outside the App Store
6 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @emaf @tj-devel709 @haritha-mohan