[dotnet] add metadata about .NET 6 EOL #18282
Conversation
Context: https://aka.ms/maui-support-policy Context: xamarin/xamarin-android@25cb50d Context: dotnet/sdk#32426 dotnet/sdk#32426 adds support for an optional workload to specify that it is no longer supported by adding an item to the `@(EolWorkload)` item group: <ItemGroup Condition=" '$(TargetPlatformIdentifier)' == 'iOS' and $([MSBuild]::VersionEquals($(TargetFrameworkVersion), '6.0')) "> <EolWorkload Include="ios" Url="https://aka.ms/maui-support-policy" /> </ItemGroup> This will cause `dotnet build` to issue a new NETSDK1202 build warning: dotnet\sdk\6.0.409\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.EolTargetFrameworks.targets(35,5): warning NETSDK1202: The workload 'ios' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/maui-support-policy for more information about the support policy. I had to update the `Makefile` to do a `@PLATFORM_LOWERCASE@` replacement for this.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)
✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
| -e "s/@PLATFORM_LOWERCASE@/$(2)/g" \ | ||
| -e "s/@TARGET_FRAMEWORK_VERSION@/$(subst net,,$(DOTNET_TFM))/g" \ | ||
| $$< > $$@.tmp | ||
| $(Q) mv $$@.tmp $$@ | ||
| endef | ||
| $(foreach platform,$(DOTNET_PLATFORMS),$(eval $(call AutoImports,$(platform)))) | ||
| $(foreach platform,$(DOTNET_PLATFORMS),$(eval $(call AutoImports,$(platform),$(shell echo $(platform) | tr A-Z a-z)))) |
There was a problem hiding this comment.
This appears to work, as I downloaded the artifact and it has this inside:
<ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'iOS' And $([MSBuild]::VersionEquals($(TargetFrameworkVersion), '6.0'))">
<EolWorkload Include="ios" Url="https://aka.ms/maui-support-policy" />
</ItemGroup>
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 77 tests passed 🎉 Tests counts
Pipeline on Agent |
|
Couldn't we do somehing like this in our .NET 8 workloads instead/as well? <ItemGroup Condition=" '$(TargetPlatformIdentifier)' == 'iOS' and $([MSBuild]::LessThan($(TargetFrameworkVersion), '7.0')) ">
<EolWorkload Include="ios" Url="https://aka.ms/maui-support-policy" />
</ItemGroup> |
|
Since this is in AutoImport.props, which is always loaded for all projects |
|
@rolfbjarne to fix .NET 8, we will probably need to do something like this: I'm still working out the details on this one. ^^ |
rolfbjarne
merged commit 701aa23
into
xamarin:release/6.0.4xx-xcode14.3
Context: https://aka.ms/maui-support-policy
Context: xamarin/xamarin-android@25cb50d
Context: dotnet/sdk#32426
dotnet/sdk#32426 adds support for an optional workload to specify that it is no longer supported by adding an item to the
@(EolWorkload)item group:This will cause
dotnet buildto issue a new NETSDK1202 build warning:I had to update the
Makefileto do a@PLATFORM_LOWERCASE@replacement for this.