[msbuild] Fix calling the GetFileSystemEntries task on Windows when not connected to a Mac. #18287
Conversation
…ot connected to a Mac. Given the following truths: * A task will (try to) connect to a Mac if its SessionId property isn't empty. * The BuildSessionId property is always set on Windows when building from an IDE (even if not connected to a remote Mac). It stands to reason that we can't use BuildSessionId to distinguish between connected/not conected status on Windows. Instead introduce a new property, BuildSessionIdIfConnected, which is only set if connected to a Mac (i.e. if 'IsMacEnabled=true'). Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1808448 (second attempt).
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 227 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
/sudo backport release/7.0.2xx-xcode14.3 |
|
Backport Job to branch release/7.0.2xx-xcode14.3 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7789057 for more details. |
…tries task on Windows when not connected to a Mac. (#18299) Given the following truths: * A task will (try to) connect to a Mac if its SessionId property isn't empty. * The BuildSessionId property is always set on Windows when building from an IDE (even if not connected to a remote Mac). It stands to reason that we can't use BuildSessionId to distinguish between connected/not conected status on Windows. Instead introduce a new property, BuildSessionIdIfConnected, which is only set if connected to a Mac (i.e. if 'IsMacEnabled=true'). Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1808448 (second attempt). Backport of #18287
|
After applying the modifications, Im still getting errors on <GetFileSystemEntries This is an example of the errors : I guess the error is caused by the ":" included at the middel of the path which is phisicaly automaticaly removed by Macintoch operating system when the files are being created but trying to read the files with the bad path cases the errors. I checked that the files do exist on the mac but with the ":" removed so "...15c29a0ceb6003645dd5ffd8bccd1d032be35349ee6d12fd8d8f8575e0a1e0db/C:/nuget/packages/xamarin.firebase.ios.cloudmessaging/8.10.0.3/lib/net6.0-ios15.4/Firebase.CloudMessaging.resources" is found on the Mac at "15c29a0ceb6003645dd5ffd8bccd1d032be35349ee6d12fd8d8f8575e0a1e0db/C/nuget/packages/xamarin.firebase.ios.cloudmessaging/8.10.0.3/lib/net6.0-ios15.4/Firebase.CloudMessaging.resources" It might be helpfull to remove any ":" inside the path |
|
@mmeissa it turned out this fix didn't work. We've since implemented a proper fix, and this is the workaround: #18308 (comment) |
Given the following truths:
It stands to reason that we can't use BuildSessionId to distinguish between
connected/not conected status on Windows. Instead introduce a new property,
BuildSessionIdIfConnected, which is only set if connected to a Mac (i.e. if
'IsMacEnabled=true').
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1808448 (second attempt).