[dotnet] Copy assemblies to AOT to a new directory if they're in a directory with a colon. Fixes #14904. #18711
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…rectory with a colon. Fixes xamarin#14904. The AOT compiler fails we pass a MONO_PATH with a colon (because Mono supports multiple paths in MONO_PATH, separated by colon...). So if we get assemblies in such a directory (which happens for remote builds, when IntermediateOutputPath is an absolute (Windows) path), copy them all to a different (temporary) directory and use that instead. It's slower, but at least it works. Fixes xamarin#14904.
rolfbjarne
force-pushed
the
issue-14904
branch
from
bf7e1a1
to
9f277e0
Compare
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 234 tests passed. Failures❌ monotouch tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2488). |
|
This was instead fixed here: #18810. |
The AOT compiler fails we pass a MONO_PATH with a colon (because Mono supports
multiple paths in MONO_PATH, separated by colon...). So if we get assemblies
in such a directory (which happens for remote builds, when
IntermediateOutputPath is an absolute (Windows) path), copy them all to a
different directory and use that instead.
It's slower, but at least it works.
Fixes #14904.