[Versions-*.plist.in] Define Feature keys #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spouliot
approved these changes
Mar 16, 2017
|
Build success |
spouliot
added
the
requires-qa-before-merge
dalexsoto
approved these changes
Mar 16, 2017
|
XS has already been updated to use these feature keys, which means that the corresponding features won't work until this has been merged (https://bugzilla.xamarin.com/show_bug.cgi?id=52717#c19) |
rolfbjarne
approved these changes
Mar 17, 2017
spouliot
suggested changes
Mar 17, 2017
| <string>mlaunch-install-progress</string> | ||
| <string>http-client-handlers</string> | ||
| <string>mono-symbol-archive</string> | ||
| <string>sgen-concurrent-gc-experimental</string> |
There was a problem hiding this comment.
That's tracking one-too-many issues. @jstedfast can you remove both <string>sgen-concurrent-gc-experimental</string> lines from the PR so the other feature can be tested. We'll do another one once for the last item once we have results from QA. Thanks.
spouliot
approved these changes
Mar 17, 2017
There was a problem hiding this comment.
QA is fine with experimental -> https://trello.com/c/FbbxRyCG/2772-qa-xi-xm-mac-and-ios-samples-with-concurrent-gc-enabled#comment-58cbf1d0ba3e214b0687a4d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.