New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MediaAccessibility] Add xcode 15 beta 7 support. #19016
Merged
dalexsoto
merged 3 commits into
xamarin:net8.0-xcode15
from
mandel-macaque:net8.0-xcode15-mediaaccessibility
Sep 18, 2023
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
tests/xtro-sharpie/api-annotations-dotnet/iOS-MediaAccessibility.todo
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
tests/xtro-sharpie/api-annotations-dotnet/macOS-MediaAccessibility.todo
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
tests/xtro-sharpie/api-annotations-dotnet/tvOS-MediaAccessibility.todo
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the options be a strong dictionary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find any documentation about the keys or values. https://developer.apple.com/documentation/mediaaccessibility/maflashinglightsprocessoroptionkey?language=objc
Or in the header: https://github.com/xamarin/xamarin-macios/wiki/MediaAccessibility-iOS-xcode15.0-b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - I also looked at the Swift doc'n and the key, oddly enough, is not an
NSString
, which is an inner struct calledMAFlashingLightsProcessor.OptionKey
which has initializers fromString
- it feels like they're keeping their options open for the future, but the values of the options are also untyped there and undocumented.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did notice the same, we should leave it as open as possible.