Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Look for and copy binding resource packages to the remote Mac in the ResolveNativeReferences task. Fixes #19229. #19325

Merged
merged 1 commit into from Oct 25, 2023
Merged

[msbuild] Look for and copy binding resource packages to the remote Mac in the ResolveNativeReferences task. Fixes #19229. #19325

merged 1 commit into from Oct 25, 2023

Conversation

rolfbjarne
Copy link
Member

Look for any binding resource packages (a directory named AssemblyName.resources
or a compressed version named AssemblyName.resources.zip) next to any references,
and copy those to the remote Mac when doing remote builds.

Fixes #19229.

@rolfbjarne
[msbuild] Look for and copy binding resource packages to the remote M…
79f0b23 
…ac in the ResolveNativeReferences task. Fixes xamarin#19229.

Look for any binding resource packages (a directory named AssemblyName.resources
or a compressed version named AssemblyName.resources.zip) next to any references,
and copy those to the remote Mac when doing remote builds.

Fixes xamarin#19229.
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Oct 24, 2023
@rolfbjarne rolfbjarne mentioned this pull request Oct 24, 2023
Merged
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Oct 24, 2023
@rolfbjarne
[release/7.0.3xx] [msbuild] Look for and copy binding resource packag…
088bdd7 
…es to the remote Mac in the ResolveNativeReferences task. Fixes xamarin#19229.

Look for any binding resource packages (a directory named AssemblyName.resources
or a compressed version named AssemblyName.resources.zip) next to any references,
and copy those to the remote Mac when doing remote builds.

Backport of xamarin#19325.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 79f0b23241cab94be3dca71e42196c98214b0dda [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 79f0b23241cab94be3dca71e42196c98214b0dda [PR build]

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (#19320).

@rolfbjarne rolfbjarne merged commit 458a11b into xamarin:main Oct 25, 2023
75 of 78 checks passed
@rolfbjarne rolfbjarne deleted the msbuild-remote-copy-binding-resource-packages branch October 25, 2023 06:44
@rolfbjarne
Copy link
Member Author

/sudo backport release/8.0.1xx

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/8.0.1xx Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8590464 for more details.

dalexsoto pushed a commit that referenced this pull request Oct 25, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/8.0.1xx] [msbuild] Look for and copy binding resource packag…
b87a808 
…es to the remote Mac in the ResolveNativeReferences task. Fixes #19229. (#19334)

Look for any binding resource packages (a directory named
AssemblyName.resources
or a compressed version named AssemblyName.resources.zip) next to any
references,
and copy those to the remote Mac when doing remote builds.

Fixes #19229.


Backport of #19325

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
dalexsoto pushed a commit that referenced this pull request Oct 25, 2023
@rolfbjarne
[release/7.0.3xx] [msbuild] Look for and copy binding resource packag…
24746c0 
…es to the remote Mac in the ResolveNativeReferences task. Fixes #19229. (#19326)

Look for any binding resource packages (a directory named
AssemblyName.resources
or a compressed version named AssemblyName.resources.zip) next to any
references,
and copy those to the remote Mac when doing remote builds.

Backport of #19325.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mauroa mauroa mauroa approved these changes

@emaf emaf emaf approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

Assignees
No one assigned
Labels
bug If an issue is a bug or a pull request a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clang++ exited with code 1
6 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mauroa @emaf @tj-devel709