Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Xamarin.Messaging to 1.12.5 #19389

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Bump Xamarin.Messaging to 1.12.5 #19389

merged 2 commits into from
Nov 13, 2023

Conversation

emaf
Copy link
Contributor

@emaf emaf commented Nov 3, 2023

No description provided.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne
Copy link
Member

Lots of build errors like this:

/Users/builder/azdo/_work/1/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/RemoveDir.cs(16,6): error CS7036: There is no argument given that corresponds to the required parameter 'engine' of 'BuildConnection.GetAsync(string, IBuildEngine4)'
/Users/builder/azdo/_work/1/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs(17,6): error CS7036: There is no argument given that corresponds to the required parameter 'engine' of 'BuildConnection.GetAsync(string, IBuildEngine4)'
/Users/builder/azdo/_work/1/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/Tasks/ACTool.cs(18,21): error CS7036: There is no argument given that corresponds to the required parameter 'engine' of 'BuildConnection.CancelAsync(string, IBuildEngine4)'
/Users/builder/azdo/_work/1/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Exec.cs(35,7): error CS7036: There is no argument given that corresponds to the required parameter 'engine' of 'BuildConnection.GetAsync(string, IBuildEngine4)'
/Users/builder/azdo/_work/1/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/Tasks/ALToolUpload.cs(19,21): error CS7036: There is no argument given that corresponds to the required parameter 'engine' of 'BuildConnection.CancelAsync(string, IBuildEngine4)'
/Users/builder/azdo/_work/1/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Exec.cs(62,21): error CS7036: There is no argument given that corresponds to the required parameter 'engine' of 'BuildConnection.CancelAsync(string, IBuildEngine4)'

Also, would this need to be backported somewhere?

@emaf
Copy link
Contributor Author

emaf commented Nov 8, 2023

For some reason some projects are picking up old test versions of the Messaging packages insteada of 1.12.3:

2023-11-03T22:23:54.2553530Z                              /Users/builder/azdo/_work/1/s/xamarin-macios/packages/xamarin.messaging.build.client/99.0.0/lib/netstandard2.0/Xamarin.Messaging.Build.Client.dll
2023-11-03T22:23:54.2555950Z                                      CopyLocal=false
2023-11-03T22:23:54.2557260Z                                      ExternallyResolved=true
2023-11-03T22:23:54.2559250Z                                      FusionName=Xamarin.Messaging.Build.Client, Version=99.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756
2023-11-03T22:23:54.2562780Z                                      HintPath=/Users/builder/azdo/_work/1/s/xamarin-macios/packages/xamarin.messaging.build.client/99.0.0/lib/netstandard2.0/Xamarin.Messaging.Build.Client.dll
2023-11-03T22:23:54.2565440Z                                      NuGetPackageId=Xamarin.Messaging.Build.Client
2023-11-03T22:23:54.2566820Z                                      NuGetPackageVersion=99.0.0
2023-11-03T22:23:54.2568510Z                                      NuGetSourceType=Package
2023-11-03T22:23:54.2572200Z                                      OriginalItemSpec=/Users/builder/azdo/_work/1/s/xamarin-macios/packages/xamarin.messaging.build.client/99.0.0/lib/netstandard2.0/Xamarin.Messaging.Build.Client.dll
2023-11-03T22:23:54.2575850Z                                      PathInPackage=lib/netstandard2.0/Xamarin.Messaging.Build.Client.dll
2023-11-03T22:23:54.2577730Z                                      Private=false
2023-11-03T22:23:54.2579380Z                                      ReferenceSourceTarget=ResolveAssemblyReference
2023-11-03T22:23:54.2581130Z                                      ResolvedFrom={HintPathFromItem}
2023-11-03T22:23:54.2582930Z                                      Version=

@emaf
Copy link
Contributor Author

emaf commented Nov 8, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@emaf
Copy link
Contributor Author

emaf commented Nov 8, 2023

@rolfbjarne this should also go into any .NET 8 branch you are planning on shipping service releases from

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne
Copy link
Member

warning NU1603: Xamarin.iOS.Tasks.Windows depends on Xamarin.Messaging.Core (>= 1.12.3) but Xamarin.Messaging.Core 1.12.3 was not found. An approximate best match of Xamarin.Messaging.Core 99.0.0 was resolved.

@rolfbjarne
Copy link
Member

Which happens because there's no Xamarin.Messaging.Core=1.12.3 in the xamarin-impl feed

@emaf emaf changed the title Bump Xamarin.Messaging to 1.12.3 Bump Xamarin.Messaging to 1.12.5 Nov 9, 2023
@emaf
Copy link
Contributor Author

emaf commented Nov 9, 2023

Let's not backport this to any branches for now

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@emaf
Copy link
Contributor Author

emaf commented Nov 10, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 4076ebe688e3e5c60eaaa5e53fe012a59fdcb736 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4076ebe688e3e5c60eaaa5e53fe012a59fdcb736 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4076ebe688e3e5c60eaaa5e53fe012a59fdcb736 [PR build]

@rolfbjarne rolfbjarne merged commit be2e1ef into main Nov 13, 2023
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants