[CoreText] Implement CTFontDescriptor.MatchFontDescriptors. Fixes #19397. #19399

rolfbjarne · 2023-11-07T09:44:34Z

Fixes #19397.

…arin#19397. Fixes xamarin#19397.

github-actions · 2023-11-07T09:50:38Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions · 2023-11-07T12:39:37Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

mandel-macaque · 2023-11-07T23:59:08Z

src/CoreText/CTFontDescriptor.cs

+				var progressDictionary = Runtime.GetNSObject<NSDictionary> (progress)!;
+				var strongDictionary = new CTFontDescriptorMatchingProgress (progressDictionary);
+				var rv = del (state, strongDictionary);
+				return rv ? (byte) 1 : (byte) 0;


We like to cast too much hehe

Suggested change

return rv ? (byte) 1 : (byte) 0;

return (byte) (rv ? 1 : 0);

Of course this is meant as a joke, no need to change a thing ;)

vs-mobiletools-engineering-service2 · 2023-11-08T09:22:21Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-11-08T09:28:53Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-11-08T09:29:53Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 52260c6a08409ab0d7b463a66e25f67afb591da7 [PR build]

vs-mobiletools-engineering-service2 · 2023-11-08T09:34:36Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-11-08T10:04:34Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 52260c6a08409ab0d7b463a66e25f67afb591da7 [PR build]

vs-mobiletools-engineering-service2 · 2023-11-08T12:08:17Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 52260c6a08409ab0d7b463a66e25f67afb591da7 [PR build]

rolfbjarne and others added 2 commits November 7, 2023 10:44

[CoreText] Implement CTFontDescriptor.MatchFontDescriptors. Fixes xam…

cbcc6c5

…arin#19397. Fixes xamarin#19397.

Auto-format source code

49d4417

This comment has been minimized.

Sign in to view

rolfbjarne and others added 2 commits November 7, 2023 13:35

Shuffle some code.

03d4195

Auto-format source code

9a66af4

This comment has been minimized.

Sign in to view

Make optimizable

b9f17a9

This comment has been minimized.

Sign in to view

mandel-macaque approved these changes Nov 7, 2023

View reviewed changes

dalexsoto approved these changes Nov 8, 2023

View reviewed changes

Use a font that exists on every platform.

52260c6

rolfbjarne marked this pull request as ready for review November 8, 2023 12:24

haritha-mohan approved these changes Nov 8, 2023

View reviewed changes

rolfbjarne merged commit c309661 into xamarin:main Nov 9, 2023
78 of 80 checks passed

rolfbjarne deleted the coretext-MatchFontDescriptors-issue-19397 branch November 9, 2023 08:11

mandel-macaque mentioned this pull request Nov 13, 2023

[Network] Add support for Xcode 15. #19418

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CoreText] Implement CTFontDescriptor.MatchFontDescriptors. Fixes #19397. #19399

[CoreText] Implement CTFontDescriptor.MatchFontDescriptors. Fixes #19397. #19399

rolfbjarne commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 7, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque Nov 7, 2023

vs-mobiletools-engineering-service2 commented Nov 8, 2023

vs-mobiletools-engineering-service2 commented Nov 8, 2023

vs-mobiletools-engineering-service2 commented Nov 8, 2023

vs-mobiletools-engineering-service2 commented Nov 8, 2023

vs-mobiletools-engineering-service2 commented Nov 8, 2023

vs-mobiletools-engineering-service2 commented Nov 8, 2023

[CoreText] Implement CTFontDescriptor.MatchFontDescriptors. Fixes #19397. #19399

[CoreText] Implement CTFontDescriptor.MatchFontDescriptors. Fixes #19397. #19399

Conversation

rolfbjarne commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 7, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque Nov 7, 2023

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Nov 8, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Nov 8, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Nov 8, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Nov 8, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Nov 8, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Nov 8, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts