Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Foundation] Fix a few issues with NSUrlConnection.SendSynchronousRequest. #19458

Merged
merged 8 commits into from Nov 20, 2023
Merged

[Foundation] Fix a few issues with NSUrlConnection.SendSynchronousRequest. #19458

merged 8 commits into from Nov 20, 2023

Commits on Nov 15, 2023

  1. [Foundation] Fix a few issues with NSUrlConnection.SendSynchronousReq… 

    …uest.

* Simplify code by using unsafe pointers.
* Add our own objc_msgSend P/Invoke to avoid depending on generated signatures.
* Enable nullability.
* Call GC.KeepAlive to ensure the request isn't collected prematurely by the GC.

The last point might do something about xamarin#19289.
    @rolfbjarne
    rolfbjarne committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    270bf7c View commit details
    Browse the repository at this point in the history

  2. Auto-format source code

    GitHub Actions Autoformatter committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    0cd1595 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Generate the whole thing.

    @rolfbjarne
    rolfbjarne committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b3842c1 View commit details
    Browse the repository at this point in the history

  2. Fix mistakes

    @rolfbjarne
    rolfbjarne committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0feddaa View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Add watchOS compat code.

    @rolfbjarne
    rolfbjarne committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    4d9e406 View commit details
    Browse the repository at this point in the history

  2. Ignore timeouts in CI.

    @rolfbjarne
    rolfbjarne committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    a21dc4d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into nsurlconnection-sendsyncrequest-fixes

    @rolfbjarne
    rolfbjarne committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    494c392 View commit details
    Browse the repository at this point in the history

  4. Exclude test from watchOS.

    @rolfbjarne
    rolfbjarne committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b3137db View commit details
    Browse the repository at this point in the history