[msbuild] Sign simulator apps by default. Fixes #18469. #19544

rolfbjarne · 2023-11-28T15:06:24Z

…-default

…efault mode for libmono-native.

github-actions · 2024-06-11T17:11:42Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

…-default

All simulator apps are signed now, which means they can't be symlinked.

We have logic that tries to detect that if a dylib inside an app needs to be signed, then the app needs to be signed too. Unfortunately there was a bug where we'd still take into account dylibs that had already been signed, which made us always (re)sign any app with a dylib. So fix this by properly removing items that don't need signing from the list of items to sign.

vs-mobiletools-engineering-service2 · 2024-06-19T08:49:24Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-06-19T09:05:39Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 09e0700711f3b18829be12a301a2755856583f0a [PR build]

vs-mobiletools-engineering-service2 · 2024-06-19T09:07:09Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: 09e0700711f3b18829be12a301a2755856583f0a [PR build]

vs-mobiletools-engineering-service2 · 2024-06-19T09:07:41Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 09e0700711f3b18829be12a301a2755856583f0a [PR build]

vs-mobiletools-engineering-service2 · 2024-06-19T09:08:27Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 09e0700711f3b18829be12a301a2755856583f0a [PR build]

vs-mobiletools-engineering-service2 · 2024-06-19T09:19:46Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 09e0700711f3b18829be12a301a2755856583f0a [PR build]

vs-mobiletools-engineering-service2 · 2024-06-19T10:36:35Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 168 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 6 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 09e0700711f3b18829be12a301a2755856583f0a [PR build]

vs-mobiletools-engineering-service2 · 2024-06-19T12:50:28Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 09e0700711f3b18829be12a301a2755856583f0a [PR build]

vs-mobiletools-engineering-service2 · 2024-06-19T13:36:33Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 09e0700711f3b18829be12a301a2755856583f0a [PR build]

vs-mobiletools-engineering-service2 · 2024-06-19T14:25:13Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 09e0700711f3b18829be12a301a2755856583f0a [PR build]

…-default

This comment has been minimized.

Sign in to view

rolfbjarne added 4 commits June 7, 2024 17:34

[msbuild] Sign simulator apps by default. Fixes xamarin#18469.

23d062b

Fixes xamarin#18469.

[tests] Update msbuild tests.

1b8bf9b

[tests] Update test.

e8ded9a

[msbuild] Simplified entitlements for the simulator.

bb08532

rolfbjarne force-pushed the codesign-simulator-by-default branch from 72e9bc4 to bb08532 Compare June 7, 2024 16:37

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits June 10, 2024 13:39

[msbuild] Silence warnings app developers can't silence themselves.

b3c66b6

Merge remote-tracking branch 'origin/main' into codesign-simulator-by…

9266820

…-default

This comment has been minimized.

Sign in to view

[tests] We can no longer symlink simulator apps, so 'static' is the d…

71e95a3

…efault mode for libmono-native.

This comment has been minimized.

Sign in to view

rolfbjarne and others added 2 commits June 11, 2024 19:07

Try something new.

a78800a

Auto-format source code

c315807

This comment has been minimized.

Sign in to view

This snowballed a bit...

6f013af

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into codesign-simulator-by…

88cd914

…-default

This comment has been minimized.

Sign in to view

Fix condition

94a2d12

This comment has been minimized.

Sign in to view

rolfbjarne added 3 commits June 19, 2024 08:03

Fix condition for a second time.

6252830

[tests] Remove the symlink mono-native mode.

12fdfa6

All simulator apps are signed now, which means they can't be symlinked.

rolfbjarne added 2 commits June 20, 2024 09:09

Merge remote-tracking branch 'origin/main' into codesign-simulator-by…

1ea22d0

…-default

Simplify

64f80ee

[msbuild] Sign simulator apps by default. Fixes #18469. #19544

Are you sure you want to change the base?

[msbuild] Sign simulator apps by default. Fixes #18469. #19544

Conversation

rolfbjarne commented Nov 28, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jun 11, 2024

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 19, 2024

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Jun 19, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jun 19, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

vs-mobiletools-engineering-service2 commented Jun 19, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Jun 19, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Jun 19, 2024

❌ [CI Build] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Jun 19, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

vs-mobiletools-engineering-service2 commented Jun 19, 2024

❌ [CI Build] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Jun 19, 2024

❌ [CI Build] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Jun 19, 2024

💻 [CI Build] Windows Integration Tests passed 💻