[src] Use proper return type for stret functions. #19682

rolfbjarne · 2023-12-20T17:48:52Z

Many, many, many years ago (before my time!) Mono didn't properly handle
P/Invokes that returned structures. The arm ABI stated that certain structures
had be returned by having the function take a hidden first argument, where the
argument would be a pointer to where the returned structure should be stored
by the called function.

We worked around this in the generator by modifying functions returning
structures to functions taking a pointer to the function to return as the
first argument.

So this:

SomeStruct SomeFunction ();

would become:

void SomeFunction (SomeStruct *retval);

This workaround isn't necessary anymore, because both Mono and CoreCLR will
just do the right thing.

Except... when the the pointer to the structure must have a specific
alignment. In that case we still need the workaround, so keep it then.

Many, many, _many_ years ago (before my time!) Mono didn't properly handle P/Invokes that returned structures. The arm ABI stated that certain structures had be returned by having the function take a hidden first argument, where the argument would be a pointer to where the returned structure should be stored by the called function. We worked around this in the generator by modifying functions returning structures to functions taking a pointer to the function to return as the first argument. So this: SomeStruct SomeFunction (); would become: void SomeFunction (SomeStruct *retval); This workaround isn't necessary anymore, because both Mono and CoreCLR will just do the right thing. Except... when the the pointer to the structure must have a specific alignment. In that case we still need the workaround, so keep it then.

…ry-workaround

vs-mobiletools-engineering-service2 · 2024-01-02T18:36:54Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-01-02T18:41:54Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-01-02T18:52:07Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-01-02T18:52:17Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: f8ebe5c6234efde24d7f62131df7237f26e34ea1 [PR build]

vs-mobiletools-engineering-service2 · 2024-01-02T19:18:43Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f8ebe5c6234efde24d7f62131df7237f26e34ea1 [PR build]

vs-mobiletools-engineering-service2 · 2024-01-03T13:54:18Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉