Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid passing null to TaskRunner.FixReferencedItems #19871

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Avoid passing null to TaskRunner.FixReferencedItems #19871

merged 3 commits into from
Jan 23, 2024

Conversation

mauroa
Copy link
Contributor

@mauroa mauroa commented Jan 22, 2024

Ensure the input properties that are meant to be fixed with the TaskRunner.FixReferencedItems invocation, might never be null

@mauroa
Avoid passing null to TaskRunner.FixReferencedItems
d7f4a9b 
Ensure the input properties that are meant to be fixed with the TaskRunner.FixReferencedItems invocation, might never be null
@mauroa mauroa added the not-notes-worthy Ignore for release notes label Jan 22, 2024
@mauroa mauroa requested a review from dalexsoto January 22, 2024 16:47
@mauroa mauroa self-assigned this Jan 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne rolfbjarne mentioned this pull request Jan 22, 2024
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 1c56fbe77ff4830fe61bfffe094bc39fe3c39c06 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (No breaking changes)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • macOS: vsdrops gist (No breaking changes)
  • Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 1c56fbe77ff4830fe61bfffe094bc39fe3c39c06 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 166 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 1c56fbe77ff4830fe61bfffe094bc39fe3c39c06 [PR build]

dalexsoto
dalexsoto approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to backport this one to our release branches once @mauroa is ready release/8.0.100-xcode15.1

@rolfbjarne
Copy link
Member

/sudo backport release/8.0.1xx-xcode15.1

@rolfbjarne rolfbjarne merged commit a4ec504 into main Jan 23, 2024
69 checks passed
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/8.0.1xx-xcode15.1 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8960862 for more details.

@rolfbjarne rolfbjarne mentioned this pull request Jan 23, 2024
Merged
rolfbjarne added a commit that referenced this pull request Jan 24, 2024
@rolfbjarne @mauroa
[release/8.0.1xx-xcode15.1] Avoid passing null to TaskRunner.FixRefer…
2ec27bb 
…encedItems (#19885)

Ensure the input properties that are meant to be fixed with the
TaskRunner.FixReferencedItems invocation, might never be null

Backport of #19871.

---------

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
Merged
@rolfbjarne rolfbjarne deleted the dev/mag/main branch February 2, 2024 17:30
dalexsoto pushed a commit that referenced this pull request Feb 6, 2024
@vs-mobiletools-engineering-service2 @mauroa @rolfbjarne
[release/7.0.3xx] Avoid passing null to TaskRunner.FixReferencedItems (…
89166ac 
…#20023)

Ensure the input properties that are meant to be fixed with the
TaskRunner.FixReferencedItems invocation, might never be null

Backport of #19871.

---------

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@rolfbjarne rolfbjarne mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@emaf emaf Awaiting requested review from emaf emaf is a code owner

Assignees

@mauroa mauroa

Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mauroa @vs-mobiletools-engineering-service2 @rolfbjarne @dalexsoto