[msbuild] Improve the UnpackLibraryResources task a bit.

[rolfbjarne]

• Unpack into a per-assembly directory. This way identically named resources from
  different assemblies won't overwrite eachother.

• Remove logic to detect overwriting of existing bundle resources, because it's broken.

  In particular this piece of code is missing a single character (there should be a ! in the condition):

  if (string.IsNullOrEmpty (logicalName))
      ignore.Add (logicalName);

  This means we're only ignoring bundle resources without LogicalName, which shouldn't
  happen. So just remove the code, since it doesn't do anything useful. A proper fix
  for resource collision is in progress and will come in a separate pull request.

• Fix task to work for incremental builds. Previously we'd detect that any resources
  had been extracted and not re-extract, but we wouldn't add those extracted resources
  to the _BundleResourceWithLogicalName item group. The end result would be that
  on incremental builds, any bundled resources wouldn't be picked up at all. Typically
  this wouldn't be a problem (because the resources would be in the resulting app
  bundle), but doing anything out of the ordinary could cause problems. The fix is
  to write the unpacked items + their metadata to a file, and load those when we
  detect that no re-extraction is necessary (this file also does double duty as a
  stamp file in the code).

• Augment WriteItemsToFile to make its Write method accessible from different classes.

• Improve logging a bit.

[rolfbjarne]

Waiting with this until #20045 is merged.

[rolfbjarne]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vs-mobiletools-engineering-service2]

📚 [PR Build] Artifacts 📚

Packages generated

View packages

• xamarin.ios-17.3.0.356.pkg
• xamarin.mac-9.3.0.356.pkg

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 623c3ddee68b38ea1ee7d7452cb7bd6594dbe8a3 [PR build]

[vs-mobiletools-engineering-service2]

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

• iOS (no change detected)
• tvOS (no change detected)
• watchOS (no change detected)
• macOS (no change detected)

NET (empty diffs)

• iOS: (empty diff detected)
• tvOS: (empty diff detected)
• MacCatalyst: (empty diff detected)
• macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• watchOS: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)
• Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

• iOS: vsdrops gist
• tvOS: vsdrops gist
• macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 623c3ddee68b38ea1ee7d7452cb7bd6594dbe8a3 [PR build]

[vs-mobiletools-engineering-service2]

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 170 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 623c3ddee68b38ea1ee7d7452cb7bd6594dbe8a3 [PR build]