Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVFoundation] Fix delegate signature for AVAudioSourceNode callbacks. #20357

Merged
merged 4 commits into from
Apr 9, 2024

Commits on Mar 21, 2024

  1. [AVFoundation] Fix delegate signature for AVAudioSourceNode callbacks.

    The signature of the callback provided when creating AVAudioSourceNode instances
    was wrong, so the callback would get corrupted data, causing crashes.
    
    Fix the callback to have the right signature (not too difficult), and also make the
    existing signature work (a bit more complicated).
    
    Note that this is the second time we've tried to fix the delegate signature for the
    AVAudioSourceNode callbacks, but now with tests, so hoping there won't be a third
    time.
    rolfbjarne committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    1ae7709 View commit details
    Browse the repository at this point in the history
  2. Auto-format source code

    GitHub Actions Autoformatter committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a709f4e View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Configuration menu
    Copy the full SHA
    0f225fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd3d9e0 View commit details
    Browse the repository at this point in the history